bukkit: Skip item meta creation if there is no payload

Author: osipxd

mimic-bukkit/api/mimic-bukkit.api

@@ -299,6 +299,7 @@ public final class ru/endlesscode/mimic/impl/vanilla/ItemMetaPayload {
 	public final fun getName ()Ljava/lang/String;
 	public fun hashCode ()I
 	public final fun isUnbreakable ()Z
+	public static final fun of (Ljava/lang/Object;)Lru/endlesscode/mimic/impl/vanilla/ItemMetaPayload;
 	public static final fun parse (Ljava/lang/String;)Lru/endlesscode/mimic/impl/vanilla/ItemMetaPayload;
 	public fun toString ()Ljava/lang/String;
 	public static final fun write$Self (Lru/endlesscode/mimic/impl/vanilla/ItemMetaPayload;Lkotlinx/serialization/encoding/CompositeEncoder;Lkotlinx/serialization/descriptors/SerialDescriptor;)V
@@ -317,6 +318,7 @@ public final class ru/endlesscode/mimic/impl/vanilla/ItemMetaPayload$$serializer
 }
 
 public final class ru/endlesscode/mimic/impl/vanilla/ItemMetaPayload$Companion {
+	public final fun of (Ljava/lang/Object;)Lru/endlesscode/mimic/impl/vanilla/ItemMetaPayload;
 	public final fun parse (Ljava/lang/String;)Lru/endlesscode/mimic/impl/vanilla/ItemMetaPayload;
 	public final fun serializer ()Lkotlinx/serialization/KSerializer;
 }

mimic-bukkit/src/main/kotlin/impl/vanilla/ItemMetaPayload.kt

@@ -60,6 +60,20 @@ public data class ItemMetaPayload(
 
     public companion object {
 
+        /**
+         * Returns [ItemMetaPayload] if it can be retrieved from the given [payload] value.
+         *
+         * Supported types are:
+         * - [ItemMetaPayload] - returns itself
+         * - [String] - tries to parse payload using [ItemMetaPayload.parse]
+         */
+        @JvmStatic
+        public fun of(payload: Any?): ItemMetaPayload? = when (payload) {
+            is ItemMetaPayload -> payload
+            is String -> parse(payload)
+            else -> null
+        }
+
         /**
          * Tries to parse [ItemMetaPayload] from the given [input].
          * Returns `null` if parsing failed or [input] is empty.

mimic-bukkit/src/main/kotlin/impl/vanilla/MinecraftItemsRegistry.kt

@@ -55,31 +55,22 @@ public class MinecraftItemsRegistry : BukkitItemsRegistry {
         val material = getMaterial(itemId) ?: return null
         val realAmount = amount.coerceIn(1, material.maxStackSize)
 
-        val minecraftPayload: ItemMetaPayload? = when (payload) {
-            is ItemMetaPayload -> payload
-            is String -> ItemMetaPayload.parse(payload)
-            null -> null
-            else -> unknownPayload(itemId, payload)
+        val minecraftPayload = ItemMetaPayload.of(payload)
+        if (payload != null && minecraftPayload == null)  {
+            Log.w("[${javaClass.simpleName}] Ignoring unsupported payload for item $itemId:\n$payload")
         }
 
-        val item = ItemStack(material, realAmount)
-        item.itemMeta = item.itemMeta?.applyPayload(minecraftPayload)
-        return item
+        return ItemStack(material, realAmount).apply {
+            if (minecraftPayload != null) itemMeta = itemMeta?.applyPayload(minecraftPayload)
+        }
     }
 
     private fun getMaterial(name: String): Material? {
         return Material.getMaterial(name.uppercase())
             ?.takeIf { it.isItem }
     }
 
-    private fun unknownPayload(itemId: String, payload: Any): ItemMetaPayload? {
-        Log.w("[${javaClass.simpleName}] Ignoring unsupported payload for item $itemId:\n$payload")
-        return null
-    }
-
-    private fun ItemMeta.applyPayload(payload: ItemMetaPayload?): ItemMeta {
-        if (payload == null) return this
-
+    private fun ItemMeta.applyPayload(payload: ItemMetaPayload): ItemMeta {
         // Apply text options
         setDisplayName(payload.name?.colorized())
         lore = payload.lore?.colorized()