bukkit-api: Make PlayerSystemProviderService.get deprecated

Author: osipxd

mimic-bukkit-api/src/main/kotlin/PlayerSystemProviderService.kt

@@ -26,6 +26,11 @@ public abstract class PlayerSystemProviderService<T : Any>(final override val id
 
     override val isEnabled: Boolean = true
 
+    /**
+     * Returns new instance of [T] is given [arg] is instance of [Player].
+     * Otherwise, throws [ClassCastException].
+     */
+    @Deprecated("Use getSystem(player) instead", ReplaceWith("this.getSystem(arg)"))
     final override fun get(arg: Any): T = getSystem(arg as Player)
 
     /** Returns new instance of [T] initialized with the given [player] object. */

mimic-bukkit/src/main/kotlin/command/ClassSystemSubcommand.kt

@@ -1,7 +1,7 @@
 /*
  * This file is part of BukkitMimic.
- * Copyright (C) 2020 Osip Fatkullin
- * Copyright (C) 2020 EndlessCode Group and contributors
+ * Copyright (C) 2021 Osip Fatkullin
+ * Copyright (C) 2021 EndlessCode Group and contributors
  *
  * BukkitMimic is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -40,7 +40,7 @@ internal class ClassSystemSubcommand(
     @Description("Show information about player's class system")
     @CommandCompletion("@players")
     fun info(sender: CommandSender, @Optional @Flags("other,defaultself") player: Player) {
-        val system = systemProvider.get(player)
+        val system = systemProvider.getSystem(player)
         sender.send(
             "&3System: &7${systemProvider.id}",
             "&3Classes: &7${system.classes}",
@@ -57,7 +57,7 @@ internal class ClassSystemSubcommand(
         @Default("all") mode: Mode,
         @Optional @Flags("other,defaultself") player: Player
     ) {
-        val system = systemProvider.get(player)
+        val system = systemProvider.getSystem(player)
         val has = if (mode == Mode.ALL) {
             system.hasAllClasses(classes.asList())
         } else {

mimic-bukkit/src/main/kotlin/command/LevelSystemSubcommand.kt

@@ -1,7 +1,7 @@
 /*
  * This file is part of BukkitMimic.
- * Copyright (C) 2020 Osip Fatkullin
- * Copyright (C) 2020 EndlessCode Group and contributors
+ * Copyright (C) 2021 Osip Fatkullin
+ * Copyright (C) 2021 EndlessCode Group and contributors
  *
  * BukkitMimic is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -45,7 +45,7 @@ internal class LevelSystemSubcommand(
     @Description("Show information about player's level system")
     @CommandCompletion("@players")
     fun info(sender: CommandSender, @Optional @Flags("other,defaultself") player: Player) {
-        val system = systemProvider.get(player)
+        val system = systemProvider.getSystem(player)
         sender.send(
             "&3System: &7${systemProvider.id}",
             "&3Level: &7%.2f".format(system.level + system.fractionalExp),
@@ -64,8 +64,8 @@ internal class LevelSystemSubcommand(
         @Optional @Flags("other,defaultself") player: Player
     ) {
         catchUnsupported {
-            val system = systemProvider.get(player)
-            @Suppress("DEPRECATION") // Allow to use exp setter
+            val system = systemProvider.getSystem(player)
+            @Suppress("DEPRECATION") // Allow using exp setter
             when (type) {
                 ExtendedValueType.LVL -> system.level = amount.toInt()
                 ExtendedValueType.TOTAL -> system.totalExp = amount
@@ -85,7 +85,7 @@ internal class LevelSystemSubcommand(
         @Optional @Flags("other,defaultself") player: Player
     ) {
         catchUnsupported {
-            val system = systemProvider.get(player)
+            val system = systemProvider.getSystem(player)
             when (type) {
                 ValueType.LVL -> system.giveLevels(amount)
                 ValueType.POINTS -> system.giveExp(amount.toDouble())
@@ -104,7 +104,7 @@ internal class LevelSystemSubcommand(
         @Optional @Flags("other,defaultself") player: Player
     ) {
         catchUnsupported {
-            val system = systemProvider.get(player)
+            val system = systemProvider.getSystem(player)
             when (type) {
                 ValueType.LVL -> system.takeLevels(amount)
                 ValueType.POINTS -> system.takeExp(amount.toDouble())
@@ -135,7 +135,7 @@ internal class LevelSystemSubcommand(
         @Default("lvl") type: ExtendedValueType,
         @Optional @Flags("other,defaultself") player: Player
     ) {
-        val system = systemProvider.get(player)
+        val system = systemProvider.getSystem(player)
         val has = when (type) {
             ExtendedValueType.LVL -> system.didReachLevel(value)
             ExtendedValueType.POINTS -> system.hasExp(value.toDouble())

mimic-bukkit/src/test/kotlin/impl/mimic/PermissionsClassSystemTest.kt

@@ -1,7 +1,7 @@
 /*
  * This file is part of BukkitMimic.
- * Copyright (C) 2020 Osip Fatkullin
- * Copyright (C) 2020 EndlessCode Group and contributors
+ * Copyright (C) 2021 Osip Fatkullin
+ * Copyright (C) 2021 EndlessCode Group and contributors
  *
  * BukkitMimic is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -25,7 +25,6 @@ import com.nhaarman.mockitokotlin2.whenever
 import org.bukkit.permissions.PermissionAttachmentInfo
 import ru.endlesscode.mimic.BukkitTestBase
 import ru.endlesscode.mimic.classes.ClassSystem
-import java.util.*
 import kotlin.test.BeforeTest
 import kotlin.test.Test
 import kotlin.test.assertFalse
@@ -39,7 +38,7 @@ class PermissionsClassSystemTest : BukkitTestBase() {
     @BeforeTest
     override fun setUp() {
         super.setUp()
-        classSystem = PermissionsClassSystem.Provider().get(player)
+        classSystem = PermissionsClassSystem.Provider().getSystem(player)
     }
 
     @Test

mimic-bukkit/src/test/kotlin/impl/vanilla/MinecraftLevelSystemTest.kt

@@ -1,7 +1,7 @@
 /*
  * This file is part of BukkitMimic.
- * Copyright (C) 2020 Osip Fatkullin
- * Copyright (C) 2020 EndlessCode Group and contributors
+ * Copyright (C) 2021 Osip Fatkullin
+ * Copyright (C) 2021 EndlessCode Group and contributors
  *
  * BukkitMimic is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -38,7 +38,7 @@ class MinecraftLevelSystemTest : BukkitTestBase() {
     @BeforeTest
     override fun setUp() {
         super.setUp()
-        levelSystem = MinecraftLevelSystem.Provider().get(player)
+        levelSystem = MinecraftLevelSystem.Provider().getSystem(player)
     }
 
     @Test