refactor: Remove extra this calls

Author: osipxd

mimic-api/src/main/kotlin/classes/ClassSystem.kt

@@ -36,7 +36,7 @@ public interface ClassSystem {
      * @return Primary class name or `null` if player has no any classes.
      */
     public val primaryClass: String?
-        get() = this.classes.firstOrNull()
+        get() = classes.firstOrNull()
 
     /**
      * List of player classes.
@@ -46,7 +46,7 @@ public interface ClassSystem {
      *
      * Never returns `null`, but can return empty [List].
      *
-     * @return List of player system names
+     * @return List of player's classes
      * @throws IllegalStateException If player-related object not exists.
      */
     public val classes: List<String>
@@ -56,17 +56,17 @@ public interface ClassSystem {
 
     /** Returns `true` if player has any of [requiredClasses]. */
     public fun hasAnyOfClasses(requiredClasses: List<String>): Boolean {
-        return requiredClasses.any { this.hasClass(it) }
+        return requiredClasses.any { hasClass(it) }
     }
 
     /** Returns `true` if player has all [requiredClasses]. */
     public fun hasAllClasses(requiredClasses: List<String>): Boolean {
-        return requiredClasses.all { this.hasClass(it) }
+        return requiredClasses.all { hasClass(it) }
     }
 
     /** Returns `true` if player has [requiredClass]. */
     public fun hasClass(requiredClass: String): Boolean {
-        return this.classes.any {
+        return classes.any {
             it.equals(requiredClass, ignoreCase = true)
         }
     }

mimic-api/src/main/kotlin/level/LevelSystem.kt

@@ -43,17 +43,17 @@ public interface LevelSystem {
      */
     public var totalExp: Double
         get() {
-            val levelExp = this.converter.levelToExp(this.level)
-            return levelExp + this.exp
+            val levelExp = converter.levelToExp(level)
+            return levelExp + exp
         }
         set(value) {
             val allowedTotalExperience = value.coerceAtLeast(0.0)
 
-            val level = this.converter.expToFullLevel(allowedTotalExperience)
-            val levelExp = this.converter.levelToExp(level)
+            val fullLevels = converter.expToFullLevel(allowedTotalExperience)
+            val levelExp = converter.levelToExp(fullLevels)
 
-            this.level = level
-            this.exp = allowedTotalExperience - levelExp
+            level = fullLevels
+            exp = allowedTotalExperience - levelExp
         }
 
     /**
@@ -65,16 +65,16 @@ public interface LevelSystem {
     public var fractionalExp: Double
         get() {
             val expToNextLevel = totalExpToNextLevel
-            val exp = this.exp.coerceAtMost(expToNextLevel - 1)
+            val exp = exp.coerceAtMost(expToNextLevel - 1)
             return if (exp <= 0.0) 0.0 else exp / expToNextLevel
         }
         set(value) {
             val allowedExp = value.coerceAtLeast(0.0)
-            if (value < 1.0) {
-                this.exp = converter.getExpToReachNextLevel(this.level) * allowedExp
+            exp = if (value < 1.0) {
+                converter.getExpToReachNextLevel(level) * allowedExp
             } else {
-                this.giveLevels(1)
-                this.exp = 0.0
+                giveLevels(1)
+                0.0
             }
         }
 
@@ -126,8 +126,8 @@ public interface LevelSystem {
      * @throws IllegalStateException If player-related object not exists
      */
     public fun takeLevels(lvlAmount: Int) {
-        val currentLevel = this.level
-        this.level = currentLevel - lvlAmount.coerceAtMost(currentLevel)
+        val currentLevel = level
+        level = currentLevel - lvlAmount.coerceAtMost(currentLevel)
     }
 
     /**
@@ -139,7 +139,7 @@ public interface LevelSystem {
      * @throws IllegalStateException If player-related object not exists
      */
     public fun giveLevels(lvlAmount: Int) {
-        this.level += lvlAmount
+        level += lvlAmount
     }
 
     /**
@@ -148,7 +148,7 @@ public interface LevelSystem {
      * @param requiredLevel Required experience level. Negative value will be interpreted as 0.
      * @return true if player player did reach required level
      */
-    public fun didReachLevel(requiredLevel: Int): Boolean = requiredLevel.coerceAtLeast(0) <= this.level
+    public fun didReachLevel(requiredLevel: Int): Boolean = requiredLevel.coerceAtLeast(0) <= level
 
     /**
      * Takes away player the amount of experience specified.
@@ -162,8 +162,8 @@ public interface LevelSystem {
      * @see giveExp
      */
     public fun takeExp(expAmount: Double) {
-        val currentTotalExp = this.totalExp
-        this.totalExp = currentTotalExp - expAmount.coerceAtMost(currentTotalExp)
+        val currentTotalExp = totalExp
+        totalExp = currentTotalExp - expAmount.coerceAtMost(currentTotalExp)
     }
 
     /**
@@ -188,13 +188,13 @@ public interface LevelSystem {
      * @return true if player player has required experience
      * @throws IllegalStateException If player-related object not exists
      */
-    public fun hasExp(requiredExp: Double): Boolean = requiredExp.coerceAtLeast(0.0) <= this.exp
+    public fun hasExp(requiredExp: Double): Boolean = requiredExp.coerceAtLeast(0.0) <= exp
 
     /**
      * Checks player has required total experience.
      * @param requiredExp Required total experience amount. Negative value will be interpreted as 0.
      * @return true if player player has required total experience
      * @throws IllegalStateException If player-related object not exists
      */
-    public fun hasExpTotal(requiredExp: Double): Boolean = requiredExp.coerceAtLeast(0.0) <= this.totalExp
+    public fun hasExpTotal(requiredExp: Double): Boolean = requiredExp.coerceAtLeast(0.0) <= totalExp
 }

mimic-bukkit/src/main/kotlin/Mimic.kt

@@ -130,7 +130,7 @@ public class Mimic : JavaPlugin() {
                 val service = constructor()
                 servicesManager.register(serviceClass.java, service, this, priority)
                 val serviceName = serviceClass.java.name
-                    .replace(Regex(".*\\.Bukkit"), "")
+                    .substringAfterLast(".Bukkit")
                     .substringBefore("$")
                 logger.info("[$serviceName] '${service.id}' found")
             }