refactor: use pip uninstall instead of folder deletion on plugin reload

When the plugin loader is destroyed (on server reload) or created (on
startup after a crash), pip uninstall all endstone_* distributions
instead of deleting the prefix folder. This avoids file-lock errors
on Windows, preserves shared dependencies across reloads for faster
loading, and handles crash recovery since _uninstall_plugins discovers
distributions dynamically rather than relying on tracked state.

Author: wu-vincent

endstone/plugin/plugin_loader.py

@@ -4,7 +4,6 @@
 import importlib
 import os
 import os.path
-import shutil
 import site
 import subprocess
 import sys
@@ -90,8 +89,38 @@ class PythonPluginLoader(PluginLoader):
 
     def __init__(self, server: Server):
         PluginLoader.__init__(self, server)
-        self._invalidate_caches()
         self._plugins: list[Plugin] = []
+        self._uninstall_plugins()
+        self._invalidate_caches()
+
+    def __del__(self) -> None:
+        self._uninstall_plugins()
+
+    @staticmethod
+    def _find_plugin_eps() -> list[EntryPoint]:
+        return [
+            ep
+            for ep in entry_points(group="endstone")
+            if ep.dist is not None and ep.dist.name.replace("_", "-").startswith("endstone-")
+        ]
+
+    @staticmethod
+    def _uninstall_plugins() -> None:
+        dists = [ep.dist.name for ep in PythonPluginLoader._find_plugin_eps()]  # type: ignore[union-attr]
+        if not dists:
+            return
+        subprocess.run(
+            [
+                sys.executable,
+                "-m",
+                "pip",
+                "uninstall",
+                *dists,
+                "-y",
+                "--quiet",
+                "--disable-pip-version-check",
+            ],
+        )
 
     def _invalidate_caches(self) -> None:
         importlib.invalidate_caches()
@@ -102,21 +131,8 @@ def _invalidate_caches(self) -> None:
         self._prefix = os.path.join("plugins", ".local")
         for site_dir in site.getsitepackages(prefixes=[self._prefix]):
             site.addsitedir(site_dir)
-            if (
-                os.path.exists(site_dir)
-                and os.path.commonpath([site_dir, self._prefix]) == self._prefix
-                and site_dir != self._prefix
-            ):
-                for directory in os.listdir(site_dir):
-                    if not os.path.isdir(os.path.join(site_dir, directory)):
-                        continue
-                    if directory.startswith("endstone_") or directory.startswith("~"):
-                        shutil.rmtree(os.path.join(site_dir, directory))
 
     def load_plugin(self, file: str) -> Plugin | None:  # type: ignore[override]
-        env = os.environ.copy()
-        env.pop("LD_PRELOAD", "")
-
         dist_name: str | None = pkginfo.Wheel(file).name
         if dist_name is None:
             raise ValueError(f"Could not determine package name from {file}")
@@ -133,7 +149,7 @@ def load_plugin(self, file: str) -> Plugin | None:  # type: ignore[override]
                 "--no-warn-script-location",
                 "--disable-pip-version-check",
             ],
-            env=env,
+
         )
 
         eps = distribution(dist_name).entry_points.select(group="endstone")
@@ -148,8 +164,7 @@ def load_plugins(self, directory: str) -> list[Plugin]:
         loaded_plugins = []
 
         if not self._plugins:
-            eps = entry_points(group="endstone")
-            for ep in eps:
+            for ep in self._find_plugin_eps():
                 plugin = self._load_plugin_from_ep(ep)
                 if plugin:
                     loaded_plugins.append(plugin)
@@ -162,17 +177,8 @@ def load_plugins(self, directory: str) -> list[Plugin]:
         return loaded_plugins
 
     def _load_plugin_from_ep(self, ep: EntryPoint) -> Plugin | None:
-        # enforce naming convention
         if ep.dist is None:
             return None
-        if not ep.dist.name.replace("_", "-").startswith("endstone-"):
-            self.server.logger.error(
-                f"Error occurred when trying to load plugin from entry point '{ep.name}': Invalid name."
-            )
-            self.server.logger.error(
-                f"The name of distribution ({ep.dist.name}) does not start with 'endstone-' or 'endstone_'."
-            )
-            return None
 
         dist_name = "endstone-" + ep.name.replace("_", "-")
         if ep.dist.name.replace("_", "-") != dist_name: