Revert some unnecessary changes and fix doc output

* Revert changes for create_link
* `total_duration` is added to SimpleTimes, and the docstring is updated to reflect this.

Author: espenbodal

docs/src/how-to/utilize-timestruct.md

@@ -39,7 +39,7 @@ op_number = length(op_duration)
 operational_periods = SimpleTimes(op_number, op_duration)
 
 # output
-SimpleTimes{Int64}(11, [4, 2, 1, 1, 2, 4, 2, 1, 1, 2, 4])
+SimpleTimes{Int64}(11, [4, 2, 1, 1, 2, 4, 2, 1, 1, 2, 4], 24)
 ```
 
 In this case, we model the day not with hourly resolution, but only have hourly resolution in the morning and afternoon.
@@ -60,7 +60,7 @@ Instead, one can also write
 operational_periods = SimpleTimes(op_duration)
 
 # output
-SimpleTimes{Int64}(11, [4, 2, 1, 1, 2, 4, 2, 1, 1, 2, 4])
+SimpleTimes{Int64}(11, [4, 2, 1, 1, 2, 4, 2, 1, 1, 2, 4], 24)
 ```
 
 and a constructor will automatically deduce that there have to be 11 operational periods.

src/model.jl

@@ -646,13 +646,15 @@ function constraints_couple(m, 𝒩::Vector{<:Node}, ℒ::Vector{<:Link}, 𝒫,
     for n ∈ 𝒩
         ℒᶠʳᵒᵐ, ℒᵗᵒ = link_sub(ℒ, n)
 
+        # Constraint for output flowrate and input links.
         if has_output(n)
             @constraint(m, [t ∈ 𝒯, p ∈ outputs(n)],
                 m[:flow_out][n, t, p] ==
                 sum(m[:link_in][l, t, p] for l ∈ ℒᶠʳᵒᵐ if p ∈ inputs(l))
             )
         end
 
+        # Constraint for input flowrate and output links.
         if has_input(n)
             @constraint(m, [t ∈ 𝒯, p ∈ inputs(n)],
                 m[:flow_in][n, t, p] ==
@@ -991,7 +993,7 @@ available node except if one wants to include as well transport between differen
 function create_node(m, n::Availability, 𝒯, 𝒫, modeltype::EnergyModel)
 
     @constraint(m, [t ∈ 𝒯, p ∈ inputs(n)],
-            m[:flow_in][n, t, p] == m[:flow_out][n, t, p]
+        m[:flow_in][n, t, p] == m[:flow_out][n, t, p]
     )
 end
 
@@ -1015,17 +1017,17 @@ function create_link(m, l::Link, 𝒯, 𝒫, modeltype::EnergyModel)
     )
     return create_link(m, 𝒯, 𝒫, l, modeltype, formulation(l))
 end
-function create_link(m, l::Direct, 𝒯, 𝒫::Vector{<:Resource}, modeltype::EnergyModel)
+function create_link(m, l::Direct, 𝒯, 𝒫, modeltype::EnergyModel)
 
     @constraint(m, [t ∈ 𝒯, p ∈ link_res(l)],
-    m[:link_out][l, t, p] == m[:link_in][l, t, p]
+        m[:link_out][l, t, p] == m[:link_in][l, t, p]
     )
 end
-function create_link(m, l::Link, 𝒯, 𝒫::Vector{<:Resource}, modeltype::EnergyModel, formulation::Formulation)
+function create_link(m, 𝒯, 𝒫, l::Link, modeltype::EnergyModel, formulation::Formulation)
 
     # Generic link in which each output corresponds to the input
     @constraint(m, [t ∈ 𝒯, p ∈ link_res(l)],
-    m[:link_out][l, t, p] == m[:link_in][l, t, p]
+        m[:link_out][l, t, p] == m[:link_in][l, t, p]
     )
 
     # Call of the function for limiting the capacity to the maximum installed capacity