New node StratPeriodDemandSink#14
Merged
Merged
Conversation
- New sink based on `PeriodDemandSink` - Demand now specified per strategic period - Individual penalties for demand periods
magnuask
approved these changes
Jul 5, 2026
magnuask
left a comment
magnuask
left a comment
Collaborator
There was a problem hiding this comment.
Overall, it looks good. I added a few comments for your consideration.
JulStraus
commented
Jul 6, 2026
JulStraus
left a comment
JulStraus
left a comment
Member
Author
There was a problem hiding this comment.
I answered your comments and updated the points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new node called
StratPeriodDemandSink. It works similar compared to aPeriodDemandSinkwith the following changes:I have not yet updated the documentation, NEWS.md and version number. I will do it once we have settled on the implemented approach.
Important
The system currently uses the same penalties for violations of the strategic demand constraints and the partition period demand constraints. This can be easily changed if desired. Let me know if you want to utilize different penalties.