Skip to content

Fix miscellaneous bugs and enhance colors#49

Merged
JulStraus merged 6 commits into
mainfrom
enhance/misc
May 19, 2026
Merged

Fix miscellaneous bugs and enhance colors#49
JulStraus merged 6 commits into
mainfrom
enhance/misc

Conversation

@Zetison
Copy link
Copy Markdown
Collaborator

@Zetison Zetison commented Apr 24, 2026

This PR fixes several bugs:

  • Fix bug that resulted in arbitrary evaluated lat-lon coordinates for children of Areas due to the arbitrary default radius of 1.0 if not provided by the design .yml input files. The bug is resolved by first computing minimal distance between areas and letting the new radius be a third of this distance.
  • Fix issue when the transmissions/links is not properly defined (e.g., from or to objects not sharing resource).
  • Fix missing investments in transmission modes in the Investment overview.

Also, more colors are added for resource aliases.

@Zetison Zetison requested a review from dqpinel April 24, 2026 14:17
@Zetison Zetison self-assigned this Apr 24, 2026
@Zetison Zetison added bug Something isn't working enhancement New feature or request labels Apr 24, 2026
@JulStraus
Copy link
Copy Markdown
Member

Not commenting on the changes, but I think we should include the bugfixes as well for a version 0.6.x, and hence, EnergyModelsBase v0.9. Once this one is merged, I can do a cherry-pick to create said release. I created branch release-0.6 branch for this.

To this end, let me know when this branch is ready to be merged. I also have to register it at that stage.

Copy link
Copy Markdown
Collaborator

@dqpinel dqpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment on adding more syntaxes to colors.yml

Comment thread src/colors.yml
@JulStraus JulStraus merged commit a5457d6 into main May 19, 2026
3 checks passed
@JulStraus JulStraus deleted the enhance/misc branch May 19, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants