FIX: CS1574: XML comment has cref attribute 'Enum' that could not be resolved#72
Open
OhFlowi wants to merge 3 commits intoEngRajabi:masterfrom
Open
FIX: CS1574: XML comment has cref attribute 'Enum' that could not be resolved#72OhFlowi wants to merge 3 commits intoEngRajabi:masterfrom
OhFlowi wants to merge 3 commits intoEngRajabi:masterfrom
Conversation
…hods to the same as the enum. Moved the generated attribute namespace to the generator namespace.
OhFlowi
changed the title
OhFlowi
changed the title
EngRajabi
reviewed
Mar 29, 2024
| /// <param name="namespaceSymbol">The namespace symbol.</param> | ||
| /// <param name="fullName">Optional. The initial full name to start with.</param> | ||
| /// <returns>The full name of the namespace.</returns> | ||
| public static string FullNamespace(this INamespaceSymbol namespaceSymbol, string fullName = null) |
Owner
There was a problem hiding this comment.
this method exist in to SymbolExtensions
Contributor
Author
There was a problem hiding this comment.
The original FullNamespace extension in the SymbolExtensions file is replaced by the new extension file. The why I already explained in the other comment.
EngRajabi
reviewed
Mar 29, 2024
| /// <summary> | ||
| /// Provides extension methods for <see cref="INamespaceSymbol"/> objects. | ||
| /// </summary> | ||
| public static class NamespaceSymbolExtensions |
Owner
There was a problem hiding this comment.
It is better to have one extension, not several
Contributor
Author
There was a problem hiding this comment.
Yes, it is better to have a single extension file for a single target, especially if you only have a few methods.
But since this new file targets INamespaceSymbol and not ISymbol like the already existing FullName extension, the new file has a reason to exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Changed the namespace of the generated extension methods to the same as the enum. Moved the generated attribute namespace to the generator namespace.
Fixes also "CS1574 XML comment has cref attribute 'Enum' that could not be resolved" bugs that have occurred since the last release.
The original #70 was closed with "duplicate #71", which is not nearly true.