Deprecate SimpleMaterial.Builder.diffuse

Author: PepperCode1

common/src/backend/java/dev/engine_room/flywheel/backend/engine/CommonCrumbling.java

@@ -1,5 +1,6 @@
 package dev.engine_room.flywheel.backend.engine;
 
+import dev.engine_room.flywheel.api.material.CardinalLightingMode;
 import dev.engine_room.flywheel.api.material.Material;
 import dev.engine_room.flywheel.api.material.Transparency;
 import dev.engine_room.flywheel.api.material.WriteMask;
@@ -19,6 +20,6 @@ public static void applyCrumblingProperties(SimpleMaterial.Builder crumblingMate
 				.writeMask(WriteMask.COLOR)
 				.useOverlay(false)
 				.useLight(false)
-				.diffuse(false);
+				.cardinalLightingMode(CardinalLightingMode.OFF);
 	}
 }

common/src/lib/java/dev/engine_room/flywheel/lib/material/Materials.java

@@ -1,5 +1,6 @@
 package dev.engine_room.flywheel.lib.material;
 
+import dev.engine_room.flywheel.api.material.CardinalLightingMode;
 import dev.engine_room.flywheel.api.material.DepthTest;
 import dev.engine_room.flywheel.api.material.Material;
 import dev.engine_room.flywheel.api.material.Transparency;
@@ -10,15 +11,15 @@ public final class Materials {
 	public static final Material SOLID_BLOCK = SimpleMaterial.builder()
 			.build();
 	public static final Material SOLID_UNSHADED_BLOCK = SimpleMaterial.builder()
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	public static final Material CUTOUT_MIPPED_BLOCK = SimpleMaterial.builder()
 			.cutout(CutoutShaders.HALF)
 			.build();
 	public static final Material CUTOUT_MIPPED_UNSHADED_BLOCK = SimpleMaterial.builder()
 			.cutout(CutoutShaders.HALF)
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	public static final Material CUTOUT_BLOCK = SimpleMaterial.builder()
@@ -28,15 +29,15 @@ public final class Materials {
 	public static final Material CUTOUT_UNSHADED_BLOCK = SimpleMaterial.builder()
 			.cutout(CutoutShaders.ONE_TENTH)
 			.mipmap(false)
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	public static final Material TRANSLUCENT_BLOCK = SimpleMaterial.builder()
 			.transparency(Transparency.ORDER_INDEPENDENT)
 			.build();
 	public static final Material TRANSLUCENT_UNSHADED_BLOCK = SimpleMaterial.builder()
 			.transparency(Transparency.ORDER_INDEPENDENT)
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	public static final Material TRIPWIRE_BLOCK = SimpleMaterial.builder()
@@ -46,7 +47,7 @@ public final class Materials {
 	public static final Material TRIPWIRE_UNSHADED_BLOCK = SimpleMaterial.builder()
 			.cutout(CutoutShaders.ONE_TENTH)
 			.transparency(Transparency.ORDER_INDEPENDENT)
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	public static final Material GLINT = SimpleMaterial.builder()
@@ -67,7 +68,6 @@ public final class Materials {
 	public static final Material TRANSLUCENT_ENTITY = SimpleMaterial.builder()
 			.transparency(Transparency.TRANSLUCENT)
 			.cutout(CutoutShaders.ONE_TENTH)
-			.blur(false)
 			.mipmap(false)
 			.build();
 

common/src/lib/java/dev/engine_room/flywheel/lib/material/SimpleMaterial.java

@@ -264,6 +264,10 @@ public Builder useLight(boolean value) {
 			return this;
 		}
 
+		/**
+		 * @deprecated Use {@link #cardinalLightingMode(CardinalLightingMode)} instead.
+		 */
+		@Deprecated(forRemoval = true)
 		public Builder diffuse(boolean value) {
 			return cardinalLightingMode(value ? CardinalLightingMode.ENTITY : CardinalLightingMode.OFF);
 		}

common/src/lib/java/dev/engine_room/flywheel/lib/model/LineModelBuilder.java

@@ -4,6 +4,7 @@
 import org.joml.Vector4fc;
 import org.lwjgl.system.MemoryUtil;
 
+import dev.engine_room.flywheel.api.material.CardinalLightingMode;
 import dev.engine_room.flywheel.api.material.Material;
 import dev.engine_room.flywheel.api.model.IndexSequence;
 import dev.engine_room.flywheel.api.model.Mesh;
@@ -22,7 +23,7 @@ public final class LineModelBuilder {
 	private static final Material MATERIAL = SimpleMaterial.builder()
 			.shaders(StandardMaterialShaders.LINE)
 			.backfaceCulling(false)
-			.diffuse(false)
+			.cardinalLightingMode(CardinalLightingMode.OFF)
 			.build();
 
 	@UnknownNullability