-
Notifications
You must be signed in to change notification settings - Fork 71
Add vscode presetting and entity toggle swim event #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LadyCailin
merged 3 commits into
EngineHub:master
from
Anatoliy057:add-entity-toggle-swim-event
Jul 2, 2025
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "recommendations": [ | ||
| "redhat.java", | ||
| "shengchen.vscode-checkstyle", | ||
| "vscjava.vscode-java-debug", | ||
| "vscjava.vscode-java-dependency", | ||
| "vscjava.vscode-java-pack", | ||
| "vscjava.vscode-java-test", | ||
| "vscjava.vscode-maven", | ||
| ], | ||
| "unwantedRecommendations": [ | ||
|
|
||
| ] | ||
| } |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "java.compile.nullAnalysis.mode": "automatic", | ||
| "java.checkstyle.configuration": "${workspaceFolder}/checkstyle.xml", | ||
| "java.checkstyle.properties": { | ||
| "config_loc": "${workspaceFolder}", | ||
| }, | ||
| "java.checkstyle.autocheck": true, | ||
| "java.format.settings.url": ".vscode/java-formatter.xml", | ||
| "[java]": { | ||
| "editor.insertSpaces": false | ||
| }, | ||
| "files.trimTrailingWhitespace": true, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
src/main/java/com/laytonsmith/abstraction/events/MCEntityToggleSwimEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.laytonsmith.abstraction.events; | ||
|
|
||
| import com.laytonsmith.abstraction.MCEntity; | ||
| import com.laytonsmith.abstraction.enums.MCEntityType; | ||
| import com.laytonsmith.core.events.BindableEvent; | ||
|
|
||
| public interface MCEntityToggleSwimEvent extends BindableEvent { | ||
|
|
||
| boolean isSwimming(); | ||
|
|
||
| MCEntity getEntity(); | ||
|
|
||
| MCEntityType getEntityType(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of matches(), override the getPrefilterBuilder() method. This new method is much faster at runtime, and offers additional benefits such as better documentation. There are several examples of this, just search for "getPrefilterBuilder" to see some examples you can learn from (player_chat for instance has been converted), or see the PrefilterBuilder class. Once you implement that method, the matches() method goes away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it, but for a player that may not exist and the id of the entity didn't appear to have any examples (or I didn't notice). For the new filter I used the documentation from a similar one, as I don't quite understand how their tags work.