Remove some unnecessary/outdated code from core plugin components

Author: me4502

.gitattributes

@@ -1,7 +1,7 @@
-* text=auto
+* text=auto eol=lf
 
 # Force Batch files to CRLF
-*.bat text=crlf
+*.bat eol=crlf -text
 
 # Java sources
 *.java          text diff=java

craftbook-bukkit/build.gradle.kts

@@ -43,7 +43,6 @@ dependencies {
     "api"(libs.worldguard.bukkit) { isTransitive = false }
 
     "localImplementation"(libs.paperApi) {
-        exclude("org.slf4j", "slf4j-api")
         exclude("junit", "junit")
     }
     "implementation"(libs.vaultApi) { isTransitive = false }

craftbook-bukkit/doctools/build.gradle.kts

@@ -36,8 +36,6 @@ repositories {
 
 dependencies {
     "implementation"(project(":craftbook-bukkit"))
-    "implementation"(libs.paperApi) {
-        exclude(group = "org.slf4j", module = "slf4j-api")
-    }
+    "implementation"(libs.paperApi);
     "implementation"("com.sk89q.worldedit:worldedit-cli:${libs.versions.worldedit.get()}")
 }

craftbook-bukkit/src/main/java/org/enginehub/craftbook/bukkit/CraftBookPlugin.java

@@ -16,15 +16,14 @@
 package org.enginehub.craftbook.bukkit;
 
 import com.google.common.base.Joiner;
-import com.sk89q.minecraft.util.commands.CommandException;
 import com.sk89q.wepif.PermissionsResolverManager;
 import com.sk89q.worldedit.extension.platform.Actor;
 import com.sk89q.worldedit.internal.command.CommandUtil;
+import net.kyori.adventure.text.Component;
+import net.kyori.adventure.text.format.NamedTextColor;
 import org.bukkit.Bukkit;
-import org.bukkit.ChatColor;
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandSender;
-import org.bukkit.command.ConsoleCommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
@@ -163,7 +162,7 @@ public void playerJoin(PlayerJoinEvent event) {
                 }
 
                 if (!foundAMech) {
-                    event.getPlayer().sendMessage(ChatColor.RED + "[CraftBook] Warning! You have no mechanics enabled, the plugin will appear to do nothing until a feature is enabled!");
+                    event.getPlayer().sendMessage(Component.text("[CraftBook] Warning! You have no mechanics enabled, the plugin will appear to do nothing until a feature is enabled!", NamedTextColor.RED));
                 }
             }
         }, this);
@@ -179,7 +178,7 @@ public void playerJoin(PlayerJoinEvent event) {
 
         if (!foundAMech) {
             Bukkit.getScheduler().runTaskTimer(this,
-                () -> getLogger().warning(ChatColor.RED + "Warning! You have no mechanics enabled, the plugin will appear to do nothing until a feature is enabled!"), 20L, 20 * 60 * 5);
+                () -> getComponentLogger().warn(Component.text("Warning! You have no mechanics enabled, the plugin will appear to do nothing until a feature is enabled!", NamedTextColor.RED)), 20L, 20 * 60 * 5);
         }
     }
 
@@ -306,37 +305,6 @@ public String[] getGroups(Player player) {
         }
     }
 
-    /**
-     * Gets the name of a command sender. This is a unique name and this
-     * method should never return a "display name".
-     *
-     * @param sender The sender to get the name of
-     * @return The unique name of the sender.
-     */
-    public String toUniqueName(CommandSender sender) {
-        if (sender instanceof ConsoleCommandSender) {
-            return "*Console*";
-        } else {
-            return sender.getName();
-        }
-    }
-
-    /**
-     * Gets the name of a command sender. This play be a display name.
-     *
-     * @param sender The CommandSender to get the name of.
-     * @return The name of the given sender
-     */
-    public String toName(CommandSender sender) {
-        if (sender instanceof ConsoleCommandSender) {
-            return "*Console*";
-        } else if (sender instanceof Player) {
-            return ((Player) sender).getDisplayName();
-        } else {
-            return sender.getName();
-        }
-    }
-
     /**
      * Checks permissions.
      *
@@ -363,22 +331,6 @@ public boolean hasPermission(CommandSender sender, String perm) {
         return false;
     }
 
-    /**
-     * Checks to see if the sender is a player, otherwise throw an exception.
-     *
-     * @param sender The {@link CommandSender} to check
-     * @return {@code sender} casted to a player
-     * @throws CommandException if {@code sender} isn't a {@link Player}
-     */
-    public static Player checkPlayer(CommandSender sender)
-        throws CommandException {
-        if (sender instanceof Player) {
-            return (Player) sender;
-        } else {
-            throw new CommandException("A player is expected.");
-        }
-    }
-
     public Actor wrapCommandSender(CommandSender sender) {
         if (sender instanceof Player) {
             return wrapPlayer((Player) sender);

craftbook-core/src/main/java/org/enginehub/craftbook/PlatformCommandManager.java

@@ -186,12 +186,6 @@ public void handleCommand(Actor actor, String arguments) {
                     .build());
             }
         } catch (CommandExecutionException e) {
-            // FIXME: Put this in an exception converter.
-            if (e.getCause() instanceof com.sk89q.minecraft.util.commands.CommandException) {
-                actor.printError(TextComponent.of(e.getCause().getMessage()));
-                return;
-            }
-
             handleUnknownException(actor, e.getCause());
         } catch (CommandException e) {
             actor.printError(TextComponent.builder("")