Speed up Fast Reorder Mode and make it default (#1653)

* Speed up Fast Reorder Mode and make it default

* Make non-exposed side effects internal

* Docs on isExposed

Author: me4502

worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java

@@ -213,7 +213,7 @@ public String getDisplayName() {
 
     private final @Nullable List<TracingExtent> tracingExtents;
 
-    private ReorderMode reorderMode = ReorderMode.MULTI_STAGE;
+    private ReorderMode reorderMode = ReorderMode.FAST;
 
     private Mask oldMask;
 

worldedit-core/src/main/java/com/sk89q/worldedit/LocalSession.java

@@ -108,7 +108,7 @@ public class LocalSession {
     private transient Mask mask;
     private transient ZoneId timezone = ZoneId.systemDefault();
     private transient BlockVector3 cuiTemporaryBlock;
-    private transient EditSession.ReorderMode reorderMode = EditSession.ReorderMode.MULTI_STAGE;
+    private transient EditSession.ReorderMode reorderMode = EditSession.ReorderMode.FAST;
     private transient List<Countable<BlockState>> lastDistribution;
     private transient World worldOverride;
     private transient boolean tickingWatchdog = true;

worldedit-core/src/main/java/com/sk89q/worldedit/command/argument/SideEffectConverter.java

@@ -59,7 +59,9 @@ public Component describeAcceptableArguments() {
 
     @Override
     public List<String> getSuggestions(String input, InjectedValueAccess context) {
-        return limitByPrefix(getSideEffects().stream().map(sideEffect -> sideEffect.name().toLowerCase(Locale.US)), input);
+        return limitByPrefix(getSideEffects().stream()
+            .filter(SideEffect::isExposed)
+            .map(sideEffect -> sideEffect.name().toLowerCase(Locale.US)), input);
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/extent/world/SideEffectExtent.java

@@ -32,10 +32,13 @@
 import com.sk89q.worldedit.world.block.BlockState;
 import com.sk89q.worldedit.world.block.BlockStateHolder;
 
+import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.Map;
 import java.util.Set;
+import java.util.function.Function;
+import java.util.stream.Collectors;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -50,6 +53,11 @@ public class SideEffectExtent extends AbstractDelegateExtent {
     private SideEffectSet sideEffectSet = SideEffectSet.defaults();
     private boolean postEditSimulation;
 
+    private static final SideEffectSet INTERNAL_NONE = new SideEffectSet(
+        Arrays.stream(SideEffect.values())
+            .collect(Collectors.toMap(Function.identity(), state -> SideEffect.State.OFF))
+    );
+
     /**
      * Create a new instance.
      *
@@ -86,7 +94,7 @@ public <B extends BlockStateHolder<B>> boolean setBlock(BlockVector3 location, B
             positions.put(location, world.getBlock(location));
         }
 
-        return world.setBlock(location, block, postEditSimulation ? SideEffectSet.none() : sideEffectSet);
+        return world.setBlock(location, block, postEditSimulation ? INTERNAL_NONE : sideEffectSet);
     }
 
     public boolean commitRequired() {

worldedit-core/src/main/java/com/sk89q/worldedit/internal/wna/WorldNativeAccess.java

@@ -167,7 +167,7 @@ default void markAndNotifyBlock(NP pos, NC chunk, NBS oldState, NBS newState, Si
         if (isChunkTicking(chunk)) {
             if (sideEffectSet.shouldApply(SideEffect.ENTITY_AI)) {
                 notifyBlockUpdate(pos, oldState, newState);
-            } else {
+            } else if (sideEffectSet.shouldApply(SideEffect.NETWORK)) {
                 // If we want to skip entity AI, just mark the block for sending
                 markBlockChanged(pos);
             }
@@ -183,7 +183,9 @@ default void markAndNotifyBlock(NP pos, NC chunk, NBS oldState, NBS newState, Si
         }
 
         // Seems used only for PoI updates
-        onBlockStateChange(pos, oldState, blockState1);
+        if (sideEffectSet.shouldApply(SideEffect.POI_UPDATE)) {
+            onBlockStateChange(pos, oldState, blockState1);
+        }
     }
 
 }

worldedit-core/src/main/java/com/sk89q/worldedit/util/SideEffect.java

@@ -22,22 +22,32 @@
 import java.util.Locale;
 
 public enum SideEffect {
-    LIGHTING(State.ON),
-    NEIGHBORS(State.ON),
-    UPDATE(State.ON),
-    VALIDATION(State.OFF),
-    ENTITY_AI(State.OFF),
-    EVENTS(State.OFF);
+    LIGHTING(State.ON, true),
+    NEIGHBORS(State.ON, true),
+    UPDATE(State.ON, true),
+    VALIDATION(State.OFF, true),
+    ENTITY_AI(State.OFF, true),
+    EVENTS(State.OFF, true),
+    /**
+     * Internal use only.
+     */
+    POI_UPDATE(State.ON, false),
+    /**
+     * Internal use only.
+     */
+    NETWORK(State.ON, false);
 
     // TODO Make these components in WE8
     private final String displayName;
     private final String description;
     private final State defaultValue;
+    private final boolean exposed;
 
-    SideEffect(State defaultValue) {
+    SideEffect(State defaultValue, boolean exposed) {
         this.displayName = "worldedit.sideeffect." + this.name().toLowerCase(Locale.US);
         this.description = "worldedit.sideeffect." + this.name().toLowerCase(Locale.US) + ".description";
         this.defaultValue = defaultValue;
+        this.exposed = exposed;
     }
 
     public String getDisplayName() {
@@ -52,6 +62,15 @@ public State getDefaultValue() {
         return this.defaultValue;
     }
 
+    /**
+     * Determines if this side effect is considered API.
+     *
+     * @return if the side effect is exposed via API
+     */
+    public boolean isExposed() {
+        return exposed;
+    }
+
     public enum State {
         OFF,
         ON,

worldedit-core/src/main/java/com/sk89q/worldedit/util/SideEffectSet.java

@@ -32,7 +32,9 @@
 public class SideEffectSet {
     private static final SideEffectSet DEFAULT = new SideEffectSet(ImmutableMap.of());
     private static final SideEffectSet NONE = new SideEffectSet(
-        Arrays.stream(SideEffect.values()).collect(Collectors.toMap(Function.identity(), state -> SideEffect.State.OFF))
+        Arrays.stream(SideEffect.values())
+            .filter(SideEffect::isExposed)
+            .collect(Collectors.toMap(Function.identity(), state -> SideEffect.State.OFF))
     );
 
     private final Map<SideEffect, SideEffect.State> sideEffects;

worldedit-core/src/main/java/com/sk89q/worldedit/util/formatting/component/SideEffectBox.java

@@ -41,6 +41,7 @@ public class SideEffectBox extends PaginationBox {
     private static final LazyReference<List<SideEffect>> SIDE_EFFECTS = LazyReference.from(() ->
         WorldEdit.getInstance().getPlatformManager().getSupportedSideEffects()
             .stream()
+            .filter(SideEffect::isExposed)
             .sorted(Comparator.comparing(effect ->
                 WorldEditText.reduceToText(
                     TranslatableComponent.of(effect.getDisplayName()),