Re-enable this-escape warning, suppress as needed (#2953)

ANTLR now suppresses it properly. We also need to generally suppress it
for now, since we use a lot of weird initialization patterns. Cleaning
these up would be nice in the future.

Author: octylFractal

build-logic/src/main/kotlin/buildlogic.common-java.gradle.kts

@@ -14,9 +14,8 @@ tasks
     .withType<JavaCompile>()
     .matching { it.name == "compileJava" || it.name == "compileTestJava" }
     .configureEach {
-        // TODO: re-enable this-escape when ANTLR suppresses it properly
         val disabledLint = listOf(
-            "processing", "path", "fallthrough", "serial", "overloads", "this-escape",
+            "processing", "path", "fallthrough", "serial", "overloads",
         )
         options.release.set(25)
         options.compilerArgs.addAll(listOf("-Xlint:all") + disabledLint.map { "-Xlint:-$it" })

worldedit-bukkit/src/main/java/com/sk89q/wepif/PermissionsResolverManager.java

@@ -100,6 +100,7 @@ public static PermissionsResolverManager getInstance() {
         FlatFilePermissionsResolver.class,
     };
 
+    @SuppressWarnings("this-escape")
     protected PermissionsResolverManager(Plugin plugin) {
         this.server = plugin.getServer();
         new ServerListener().register(plugin); // Register the events

worldedit-core-mc/src/main/java/com/sk89q/worldedit/coremc/internal/CoreMcPlatform.java

@@ -79,6 +79,7 @@ public abstract class CoreMcPlatform extends AbstractPlatform implements MultiUs
     private boolean hookingEvents = false;
     private CoreMcPermissionsProvider permissionsProvider;
 
+    @SuppressWarnings("this-escape")
     protected CoreMcPlatform(CoreMcMod mod, Lifecycled<MinecraftServer> server) {
         this.mod = mod;
         this.dataFixer = new CoreMcDataFixer(this, getDataVersion());

worldedit-core-mc/src/main/java/com/sk89q/worldedit/coremc/internal/CoreMcPlayer.java

@@ -66,11 +66,7 @@ public CoreMcPlayer(CoreMcPlatform platform, ServerPlayer player) {
         this.platform = platform;
         this.player = player;
 
-        if (getUniqueId() == null) {
-            throw new AssertionError("Player UUID cannot be null");
-        }
-
-        ThreadSafeCache.getInstance().getOnlineIds().add(getUniqueId());
+        ThreadSafeCache.getInstance().getOnlineIds().add(player.getUUID());
     }
 
     @Override

worldedit-core/src/legacy/java/com/sk89q/worldedit/blocks/SkullBlock.java

@@ -54,6 +54,7 @@ public SkullBlock(BlockState state) {
      * @param blockState BlockState to set
      * @param owner name of player
      */
+    @SuppressWarnings("this-escape")
     public SkullBlock(BlockState blockState, String owner) {
         super(blockState);
         this.setOwner(owner);

worldedit-core/src/main/java/com/sk89q/worldedit/extension/input/ParserContext.java

@@ -56,13 +56,13 @@ public ParserContext() {
      * @param other the other instance
      */
     public ParserContext(ParserContext other) {
-        setExtent(other.getExtent());
-        setSession(other.getSession());
-        setWorld(other.getWorld());
-        setActor(other.getActor());
-        setRestricted(other.isRestricted());
-        setPreferringWildcard(other.isPreferringWildcard());
-        setTryLegacy(other.isTryingLegacy());
+        this.extent = other.extent;
+        this.session = other.session;
+        this.world = other.world;
+        this.actor = other.actor;
+        this.restricted = other.restricted;
+        this.tryLegacy = other.tryLegacy;
+        this.preferringWildcard = other.preferringWildcard;
     }
 
     /**

worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/AbstractPlatform.java

@@ -39,13 +39,15 @@
 public abstract class AbstractPlatform implements Platform {
 
     private final ResourceLoader resourceLoader = new WorldEditResourceLoader(WorldEdit.getInstance());
+    @SuppressWarnings("this-escape")
     private final LazyReference<ArchiveUnpacker> archiveUnpacker = LazyReference.from(() -> {
         try {
             return new ArchiveUnpacker(getConfiguration().getWorkingDirectoryPath().resolve(".archive-unpack"));
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         }
     });
+    @SuppressWarnings("this-escape")
     private final LazyReference<TranslationManager> translationManager = LazyReference.from(() -> {
         try {
             return new TranslationManager(archiveUnpacker.getValue(), getResourceLoader());

worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/PlatformManager.java

@@ -94,6 +94,7 @@ public class PlatformManager {
      *
      * @param worldEdit the WorldEdit instance
      */
+    @SuppressWarnings("this-escape")
     public PlatformManager(WorldEdit worldEdit) {
         checkNotNull(worldEdit);
         this.worldEdit = worldEdit;

worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/BlockArrayClipboard.java

@@ -45,6 +45,10 @@
  */
 public class BlockArrayClipboard implements Clipboard {
 
+    private static BlockVector3 getDimensions(Region region) {
+        return region.getMaximumPoint().subtract(region.getMinimumPoint()).add(1, 1, 1);
+    }
+
     private final Region region;
     private BlockVector3 origin;
     /**
@@ -73,7 +77,7 @@ public BlockArrayClipboard(Region region) {
         this.region = region.clone();
         this.origin = region.getMinimumPoint();
 
-        BlockVector3 dimensions = getDimensions();
+        BlockVector3 dimensions = getDimensions(region);
         blocks = new BaseBlock[dimensions.x() * dimensions.y() * dimensions.z()];
         yStride = dimensions.x();
         zStride = yStride * dimensions.y();
@@ -100,7 +104,7 @@ public void setOrigin(BlockVector3 origin) {
 
     @Override
     public BlockVector3 getDimensions() {
-        return region.getMaximumPoint().subtract(region.getMinimumPoint()).add(1, 1, 1);
+        return getDimensions(region);
     }
 
     @Override

worldedit-core/src/main/java/com/sk89q/worldedit/function/mask/AbstractExtentMask.java

@@ -36,7 +36,7 @@ public abstract class AbstractExtentMask extends AbstractMask {
      * @param extent the extent
      */
     protected AbstractExtentMask(Extent extent) {
-        setExtent(extent);
+        this.extent = extent;
     }
 
     /**