Lazify some more conversions

Author: octylFractal

worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BaseBlock.java

@@ -100,7 +100,7 @@ public BlockType getBlockType() {
 
     @Override
     public <V> BaseBlock with(Property<V> property, V value) {
-        return this.blockState.with(property, value).toBaseBlock(getNbt());
+        return this.blockState.with(property, value).toBaseBlock(getNbtReference());
     }
 
     /**

worldedit-fabric/src/main/java/com/sk89q/worldedit/fabric/FabricWorld.java

@@ -51,6 +51,7 @@
 import com.sk89q.worldedit.util.SideEffect;
 import com.sk89q.worldedit.util.SideEffectSet;
 import com.sk89q.worldedit.util.TreeGenerator.TreeType;
+import com.sk89q.worldedit.util.concurrency.LazyReference;
 import com.sk89q.worldedit.util.io.file.SafeFiles;
 import com.sk89q.worldedit.util.nbt.CompoundBinaryTag;
 import com.sk89q.worldedit.world.AbstractWorld;
@@ -426,7 +427,7 @@ private void regenForWorld(Region region, Extent extent, ServerWorld serverWorld
             if (blockEntity != null) {
                 net.minecraft.nbt.CompoundTag tag = new net.minecraft.nbt.CompoundTag();
                 blockEntity.toTag(tag);
-                state = state.toBaseBlock(NBTConverter.fromNative(tag));
+                state = state.toBaseBlock(LazyReference.from(() -> NBTConverter.fromNative(tag)));
             }
             extent.setBlock(vec, state.toBaseBlock());
 
@@ -602,7 +603,7 @@ public BaseBlock getFullBlock(BlockVector3 position) {
         if (tile != null) {
             net.minecraft.nbt.CompoundTag tag = new net.minecraft.nbt.CompoundTag();
             tile.toTag(tag);
-            return getBlock(position).toBaseBlock(NBTConverter.fromNative(tag));
+            return getBlock(position).toBaseBlock(LazyReference.from(() -> NBTConverter.fromNative(tag)));
         } else {
             return getBlock(position).toBaseBlock();
         }

worldedit-forge/src/main/java/com/sk89q/worldedit/forge/ForgeWorld.java

@@ -51,6 +51,7 @@
 import com.sk89q.worldedit.util.SideEffect;
 import com.sk89q.worldedit.util.SideEffectSet;
 import com.sk89q.worldedit.util.TreeGenerator.TreeType;
+import com.sk89q.worldedit.util.concurrency.LazyReference;
 import com.sk89q.worldedit.util.io.file.SafeFiles;
 import com.sk89q.worldedit.util.nbt.CompoundBinaryTag;
 import com.sk89q.worldedit.world.AbstractWorld;
@@ -437,7 +438,7 @@ private void regenForWorld(Region region, Extent extent, ServerWorld serverWorld
             if (blockEntity != null) {
                 CompoundNBT tag = new CompoundNBT();
                 blockEntity.write(tag);
-                state = state.toBaseBlock(NBTConverter.fromNative(tag));
+                state = state.toBaseBlock(LazyReference.from(() -> NBTConverter.fromNative(tag)));
             }
             extent.setBlock(vec, state.toBaseBlock());
 
@@ -610,7 +611,10 @@ public BaseBlock getFullBlock(BlockVector3 position) {
         TileEntity tile = getWorld().getChunk(pos).getTileEntity(pos);
 
         if (tile != null) {
-            return getBlock(position).toBaseBlock(NBTConverter.fromNative(TileEntityUtils.copyNbtData(tile)));
+            CompoundNBT tag = TileEntityUtils.copyNbtData(tile);
+            return getBlock(position).toBaseBlock(
+                LazyReference.from(() -> NBTConverter.fromNative(tag))
+            );
         } else {
             return getBlock(position).toBaseBlock();
         }