Synchronize YamlRegionFile#saveAll

TomyLobo · web-flow · commit 44516baa617a · 2023-06-11T00:07:43.000+02:00
This prevents multiple invocations of the method from intersecting, which could potentially cause the .tmp file to be overwritten before being renamed, thus corrupting the region storage
diff --git a/worldguard-core/src/main/java/com/sk89q/worldguard/protection/managers/storage/file/YamlRegionFile.java b/worldguard-core/src/main/java/com/sk89q/worldguard/protection/managers/storage/file/YamlRegionFile.java
@@ -190,7 +190,7 @@ public Set<ProtectedRegion> loadAll(FlagRegistry flagRegistry) throws StorageExc
     }
 
     @Override
-    public void saveAll(Set<ProtectedRegion> regions) throws StorageException {
+    public synchronized void saveAll(Set<ProtectedRegion> regions) throws StorageException {
         checkNotNull(regions);
 
         File tempFile = new File(file.getParentFile(), file.getName() + ".tmp");

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ public Set<ProtectedRegion> loadAll(FlagRegistry flagRegistry) throws StorageExc`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`@Override`
`193`		`- public void saveAll(Set<ProtectedRegion> regions) throws StorageException {`
	`193`	`+ public synchronized void saveAll(Set<ProtectedRegion> regions) throws StorageException {`
`194`	`194`	`checkNotNull(regions);`
`195`	`195`
`196`	`196`	`File tempFile = new File(file.getParentFile(), file.getName() + ".tmp");`