Updates

Author: PDowney

.github/workflows/wp-compatibility-test.yml

@@ -131,9 +131,11 @@ jobs:
           composer global require --dev wp-coding-standards/wpcs:"^3.0"
           composer global require --dev phpcompatibility/php-compatibility:"^9.3"
           composer global require --dev phpcompatibility/phpcompatibility-wp:"^2.1" 
-
           composer global require --dev dealerdirect/phpcodesniffer-composer-installer:"^1.0"
           
+          # Install VIP standards (required for our phpcs.xml)
+          composer global require --dev automattic/vipwpcs:"^3.0"
+          
           # Add composer bin to PATH
           echo "$HOME/.composer/vendor/bin" >> $GITHUB_PATH
           

phpcs.xml

@@ -145,12 +145,8 @@
     </rule>
 
     <!-- WordPress.PHP.YodaConditions -->
-    <rule ref="WordPress.PHP.YodaConditions">
-        <!-- Allow non-Yoda conditions for better readability in some contexts -->
-        <properties>
-            <property name="allow" value="comparison,assignment"/>
-        </properties>
-    </rule>
+    <!-- Note: Yoda conditions are required by WordPress standards -->
+    <rule ref="WordPress.PHP.YodaConditions"/>
 
     <!-- Generic.Commenting.Fixme -->
     <rule ref="Generic.Commenting.Fixme">

simple-wp-site-exporter.php

@@ -447,7 +447,7 @@ function sse_create_site_archive( $export_paths, $database_file ) {
         return new WP_Error( 'zip_create_failed', sprintf( 
             /* translators: %s: filename */
             __( 'Could not create zip file at %s', 'Simple-WP-Site-Exporter' ), 
-            basename($zip_filepath) 
+            basename($zip_filepath) // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.system_calls_basename -- Safe usage: $zip_filepath is constructed from controlled inputs (WordPress upload dir + sanitized filename), not user input
         ) );
     }