Fixes

Author: PDowney

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **Bug**: Removed a redundant `is_array()` check in `es_optimizer_disable_emojis_tinymce()` after adding a strict `array` parameter type, resolving a PHPStan always-true warning on PHP 8.3
 - **Critical**: Fixed License URI in plugin header and readme.txt pointing to GPL 2.0 instead of GPL 3.0
 - **Critical**: Fixed release workflow producing incomplete zip files missing `languages/` directory and `readme.txt`
 - **Bug**: Fixed changelog parser in release workflow that could not match `## [VERSION]` heading format in CHANGELOG.md, resulting in empty release bodies

composer.json

@@ -14,17 +14,17 @@
     "php": ">=7.4"
   },
   "require-dev": {
-    "phpunit/phpunit": "9.*",
-    "yoast/phpunit-polyfills": "2.*",
-    "squizlabs/php_codesniffer": "3.*",
-    "wp-coding-standards/wpcs": "3.*",
-    "phpcsstandards/phpcsextra": "1.*",
-    "dealerdirect/phpcodesniffer-composer-installer": "1.*",
-    "friendsofphp/php-cs-fixer": "3.*",
-    "php-stubs/wordpress-stubs": "6.*",
-    "szepeviktor/phpstan-wordpress": "2.*",
-    "phpstan/phpstan": "2.*",
-    "phpcompatibility/phpcompatibility-wp": "2.*"
+    "phpunit/phpunit": "^9.*",
+    "yoast/phpunit-polyfills": "^2.*",
+    "squizlabs/php_codesniffer": "^3.*",
+    "wp-coding-standards/wpcs": "^3.*",
+    "phpcsstandards/phpcsextra": "^1.*",
+    "dealerdirect/phpcodesniffer-composer-installer": "^1.*",
+    "friendsofphp/php-cs-fixer": "^3.*",
+    "php-stubs/wordpress-stubs": "^6.*",
+    "szepeviktor/phpstan-wordpress": "^2.*",
+    "phpstan/phpstan": "^2.*",
+    "phpcompatibility/phpcompatibility-wp": "^2.*"
   },
   "scripts": {
     "phpcs": "phpcs --standard=phpcs.xml",

enginescript-site-optimizer.php

@@ -767,10 +767,7 @@ function es_optimizer_add_settings_link( array $links ): array {
  * @param array $plugins Array of TinyMCE plugins.
  * @return array Difference betwen the two arrays.
  */
-function es_optimizer_disable_emojis_tinymce( $plugins ): array {
-	if ( ! is_array( $plugins ) ) {
-		$plugins = array();
-	}
+function es_optimizer_disable_emojis_tinymce( array $plugins ): array {
 	return array_diff( $plugins, array( 'wpemoji' ) );
 }
 

readme.txt

@@ -44,6 +44,7 @@ No, the plugin has a simple interface where you can toggle features on and off.
 == Changelog ==
 
 = Unreleased =
+* **BUG FIX**: Removed a redundant `is_array()` check in `es_optimizer_disable_emojis_tinymce()` after adding a strict `array` parameter type, resolving a PHPStan always-true warning on PHP 8.3
 * **BUG FIX (Critical)**: Fixed License URI pointing to GPL 2.0 instead of GPL 3.0 in plugin header and readme.txt
 * **BUG FIX (Critical)**: Fixed release workflow producing incomplete zip files missing `languages/` directory and `readme.txt`
 * **BUG FIX**: Fixed changelog parser in release workflow that could not match heading format in CHANGELOG.md