Bug Fixes

Author: PDowney

.github/workflows/update-pot-file.yml

@@ -7,10 +7,6 @@ on:
       - '**.php'
       - '**.js'
       - '.github/workflows/update-pot-file.yml'
-    paths-ignore:
-      - 'README.md'
-      - 'CHANGELOG.md'
-      - 'GEMINI.md'
   workflow_dispatch:
 
 permissions:

includes/class-fgcbg-coupon-generator.php

@@ -53,7 +53,7 @@ class FGCBG_Coupon_Generator {
 	 * Generate coupons.
 	 *
 	 * @since 1.0.0
-	 * @param array  $product_ids      Array of product IDs to generate coupons for.
+	 * @param array<int> $product_ids      Array of product IDs to generate coupons for.
 	 * @param int    $number_of_coupons Number of coupons to generate.
 	 * @param string $prefix           Coupon prefix.
 	 * @param string $discount_type    Type of discount.
@@ -81,8 +81,8 @@ public function generate_coupons( $product_ids, $number_of_coupons, $prefix = ''
 	 * Validate products for coupon generation.
 	 *
 	 * @since 1.0.0
-	 * @param array|int $product_ids Product IDs to validate.
-	 * @return array Array of valid product objects keyed by ID.
+	 * @param array<int>|int $product_ids Product IDs to validate.
+	 * @return array<int, WC_Product> Array of valid product objects keyed by ID.
 	 */
 	private function validate_products( $product_ids ) {
 		if ( ! is_array( $product_ids ) ) {
@@ -107,14 +107,17 @@ private function validate_products( $product_ids ) {
 	 * @param int    $number_of_coupons Number of coupons to generate.
 	 * @param string $prefix           Coupon prefix.
 	 * @param string $discount_type    Type of discount.
-	 * @return array Generation parameters array.
+	 * @return array{count:int, prefix:string, discount_type:string, expiry_days:int, max_attempts:int} Generation parameters array.
 	 */
 	private function prepare_generation_params( $number_of_coupons, $prefix, $discount_type ) {
+		$count       = (int) apply_filters( 'fgcbg_max_coupons_per_batch', $number_of_coupons );
+		$expiry_days = (int) apply_filters( 'fgcbg_coupon_expiry_days', self::DEFAULT_EXPIRY_DAYS );
+
 		return array(
-			'count'         => apply_filters( 'fgcbg_max_coupons_per_batch', $number_of_coupons ),
+			'count'         => $count,
 			'prefix'        => $prefix,
 			'discount_type' => $discount_type,
-			'expiry_days'   => apply_filters( 'fgcbg_coupon_expiry_days', self::DEFAULT_EXPIRY_DAYS ),
+			'expiry_days'   => $expiry_days,
 			'max_attempts'  => $number_of_coupons * 2,
 		);
 	}
@@ -123,8 +126,8 @@ private function prepare_generation_params( $number_of_coupons, $prefix, $discou
 	 * Prepare gift information for coupons.
 	 *
 	 * @since 1.0.0
-	 * @param array $valid_products Array of valid product objects.
-	 * @return array Gift information array.
+	 * @param array<int, WC_Product> $valid_products Array of valid product objects.
+	 * @return array<int, array{product_id:int, variation_id:int, quantity:int}> Gift information array.
 	 */
 	private function prepare_gift_info( $valid_products ) {
 		$gift_info = array();
@@ -142,9 +145,9 @@ private function prepare_gift_info( $valid_products ) {
 	 * Execute the coupon generation process.
 	 *
 	 * @since 1.0.0
-	 * @param array $valid_products Array of valid product objects.
-	 * @param array $gift_info      Gift information array.
-	 * @param array $params         Generation parameters.
+	 * @param array<int, WC_Product> $valid_products Array of valid product objects.
+	 * @param array<int, array{product_id:int, variation_id:int, quantity:int}> $gift_info Gift information array.
+	 * @param array{count:int, prefix:string, discount_type:string, expiry_days:int, max_attempts:int} $params Generation parameters.
 	 * @return int Number of coupons generated.
 	 */
 	private function execute_coupon_generation( $valid_products, $gift_info, $params ) {
@@ -174,9 +177,9 @@ private function execute_coupon_generation( $valid_products, $gift_info, $params
 	 * Create a single coupon.
 	 *
 	 * @since 1.0.0
-	 * @param array $valid_products Array of valid product objects.
-	 * @param array $gift_info      Gift information array.
-	 * @param array $params         Generation parameters.
+	 * @param array<int, WC_Product> $valid_products Array of valid product objects.
+	 * @param array<int, array{product_id:int, variation_id:int, quantity:int}> $gift_info Gift information array.
+	 * @param array{count:int, prefix:string, discount_type:string, expiry_days:int, max_attempts:int} $params Generation parameters.
 	 * @param int   $current_number Current coupon number in batch.
 	 * @return bool True if coupon was created successfully, false otherwise.
 	 */
@@ -205,8 +208,8 @@ private function create_single_coupon( $valid_products, $gift_info, $params, $cu
 	 * @since 1.0.0
 	 * @param WC_Coupon $coupon         The coupon object.
 	 * @param string    $code           The coupon code.
-	 * @param array     $valid_products Array of valid product objects.
-	 * @param array     $params         Generation parameters.
+	 * @param array<int, WC_Product> $valid_products Array of valid product objects.
+	 * @param array{count:int, prefix:string, discount_type:string, expiry_days:int, max_attempts:int} $params Generation parameters.
 	 * @param int       $current_number Current coupon number in batch.
 	 * @return void
 	 */
@@ -238,8 +241,8 @@ private function set_coupon_properties( $coupon, $code, $valid_products, $params
 	 *
 	 * @since 1.0.0
 	 * @param WC_Coupon $coupon    The coupon object.
-	 * @param array     $gift_info Gift information array.
-	 * @param array     $params    Generation parameters.
+	 * @param array<int, array{product_id:int, variation_id:int, quantity:int}> $gift_info Gift information array.
+	 * @param array{count:int, prefix:string, discount_type:string, expiry_days:int, max_attempts:int} $params Generation parameters.
 	 * @return void
 	 */
 	private function set_coupon_metadata( $coupon, $gift_info, $params ) {

includes/class-fgcbg-plugin.php

@@ -191,14 +191,20 @@ public function enqueue_admin_scripts( $hook ) {
 			'fgcbg_i18n',
 			array(
 				'ajax_url'               => admin_url( 'admin-ajax.php' ),
-				'nonce'                  => wp_create_nonce( 'fgcbg_ajax_nonce' ),			/* translators: %d is the number of coupons to be generated */				'confirm_large_batch'    => __( 'You are about to generate %d coupons. This may take a while and could potentially timeout depending on your server settings. Do you want to continue?', 'free-gift-coupons-bulk-coupons-generator' ),
+				'nonce'                  => wp_create_nonce( 'fgcbg_ajax_nonce' ),
+				/* translators: %d is the number of coupons to be generated. */
+				'confirm_large_batch'    => __( 'You are about to generate %d coupons. This may take a while and could potentially timeout depending on your server settings. Do you want to continue?', 'free-gift-coupons-bulk-coupons-generator' ),
 				'max_coupons_warning'    => __( 'Maximum 100 coupons allowed', 'free-gift-coupons-bulk-coupons-generator' ),
 				'many_coupons_warning'   => __( 'Generating many coupons may take some time and could timeout', 'free-gift-coupons-bulk-coupons-generator' ),
 				'select_product'         => __( 'Please select at least one product.', 'free-gift-coupons-bulk-coupons-generator' ),
 				'invalid_coupon_count'   => __( 'Please enter a valid number of coupons (minimum 1).', 'free-gift-coupons-bulk-coupons-generator' ),
 				'max_coupon_count'       => __( 'Maximum number of coupons is 100.', 'free-gift-coupons-bulk-coupons-generator' ),
 				'prefix_too_long'        => __( 'Coupon prefix must be 10 characters or less.', 'free-gift-coupons-bulk-coupons-generator' ),
-				'generation_in_progress' => __( 'Coupon generation is in progress. Are you sure you want to leave this page?', 'free-gift-coupons-bulk-coupons-generator' ),			/* translators: %1$d is the current coupon count, %2$d is the total number of coupons to generate */				'generating_progress'    => __( 'Generating coupons: %1$d of %2$d', 'free-gift-coupons-bulk-coupons-generator' ),			/* translators: %d is the number of successfully generated coupons */				'generation_complete'    => __( 'Successfully generated %d coupons.', 'free-gift-coupons-bulk-coupons-generator' ),
+				'generation_in_progress' => __( 'Coupon generation is in progress. Are you sure you want to leave this page?', 'free-gift-coupons-bulk-coupons-generator' ),
+				/* translators: %1$d is the current coupon count, %2$d is the total number of coupons to generate. */
+				'generating_progress'    => __( 'Generating coupons: %1$d of %2$d', 'free-gift-coupons-bulk-coupons-generator' ),
+				/* translators: %d is the number of successfully generated coupons. */
+				'generation_complete'    => __( 'Successfully generated %d coupons.', 'free-gift-coupons-bulk-coupons-generator' ),
 				'generation_failed'      => __( 'Failed to generate coupons. Please try again.', 'free-gift-coupons-bulk-coupons-generator' ),
 			)
 		);

phpstan.neon

@@ -13,8 +13,14 @@ parameters:
 
     bootstrapFiles:
         - vendor/php-stubs/wordpress-stubs/wordpress-stubs.php
+
+    dynamicConstantNames:
+        - FGCBG_PLUGIN_URL
+        - FGCBG_PLUGIN_VERSION
 
     treatPhpDocTypesAsCertain: false
+
+    reportUnmatchedIgnoredErrors: false
 
     ignoreErrors:
         # Ignore WordPress global variables that might not be defined in test context