Skip to content

Commit ddb218e

Browse files
authored
Merge pull request #257 from Enigmatis/release-8.1
Release 8.1
2 parents 26e6ce2 + 616014f commit ddb218e

File tree

9 files changed

+118
-50
lines changed

9 files changed

+118
-50
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ If you would like to use a tool that creates a graphql spring boot server using
3737

3838
```groovy
3939
dependencies {
40-
compile "io.github.graphql-java:graphql-java-annotations:8.0.1"
40+
compile "io.github.graphql-java:graphql-java-annotations:8.1"
4141
}
4242
```
4343

@@ -47,7 +47,7 @@ dependencies {
4747
<dependency>
4848
<groupId>io.github.graphql-java</groupId>
4949
<artifactId>graphql-java-annotations</artifactId>
50-
<version>8.0.1</version>
50+
<version>8.1</version>
5151
</dependency>
5252
```
5353

@@ -250,7 +250,7 @@ public String field(@GraphQLDefaultValue(DefaultValue.class) String value) {
250250
The `DefaultValue` class can define a `getInstance` method that will be called instead of the default constructor.
251251

252252
`@GraphQLDeprecate` and Java's `@Deprecated` can be used to specify a deprecated
253-
field.
253+
field or method.
254254

255255
### Custom data fetcher
256256

build.gradle

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,18 @@ buildscript {
66
mavenCentral()
77
}
88
dependencies {
9-
classpath 'biz.aQute.bnd:biz.aQute.bnd.gradle:3.1.0'
9+
classpath 'biz.aQute.bnd:biz.aQute.bnd.gradle:5.1.2'
1010
}
1111
}
1212
plugins {
13-
id "com.jfrog.bintray" version "1.8.4"
14-
id 'net.researchgate.release' version '2.3.4'
15-
id "com.github.hierynomus.license" version "0.14.0"
13+
id 'com.jfrog.bintray' version '1.8.5'
14+
id 'net.researchgate.release' version '2.8.1'
15+
id 'com.github.hierynomus.license' version '0.15.0'
1616
}
1717

1818
apply plugin: 'java'
1919
apply plugin: 'idea'
2020

21-
apply plugin: 'osgi'
2221
apply plugin: 'biz.aQute.bnd.builder'
2322
apply plugin: 'com.jfrog.bintray'
2423
apply plugin: 'maven-publish'
@@ -43,12 +42,6 @@ release {
4342
failOnCommitNeeded = false
4443
}
4544

46-
jar {
47-
manifest {
48-
instruction 'Import-Package', 'javax.validation.constraints', '*'
49-
}
50-
}
51-
5245
repositories {
5346
mavenCentral()
5447
}
@@ -182,7 +175,6 @@ task bundle(type: Bundle) {
182175
bndfile = file('bundle.bnd')
183176
}
184177

185-
task wrapper(type: Wrapper) {
186-
gradleVersion = '2.0'
178+
wrapper {
179+
gradleVersion = '6.5.1'
187180
}
188-

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ org.gradle.daemon=true
55
org.gradle.parallel=true
66
org.gradle.jvmargs=-Dfile.encoding=UTF-8
77

8-
version = 8.0.1
8+
version = 8.1

gradle/wrapper/gradle-wrapper.jar

5.63 KB
Binary file not shown.
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
#Thu Jun 22 22:50:08 AEST 2017
21
distributionBase=GRADLE_USER_HOME
32
distributionPath=wrapper/dists
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0-all.zip

gradlew

Lines changed: 41 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gradlew.bat

Lines changed: 17 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main/java/graphql/annotations/annotationTypes/GraphQLDeprecate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.lang.annotation.RetentionPolicy;
2020
import java.lang.annotation.Target;
2121

22-
@Target(ElementType.METHOD)
22+
@Target({ElementType.METHOD, ElementType.FIELD})
2323
@Retention(RetentionPolicy.RUNTIME)
2424
public @interface GraphQLDeprecate {
2525
String value() default "";

src/test/java/graphql/annotations/processor/retrievers/fieldBuilders/DeprecateBuilderTest.java

Lines changed: 48 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,22 @@
1717
import graphql.annotations.annotationTypes.GraphQLDeprecate;
1818
import org.testng.annotations.Test;
1919

20+
import java.lang.reflect.Field;
2021
import java.lang.reflect.Method;
2122

2223
import static org.testng.AssertJUnit.assertEquals;
2324
import static org.testng.AssertJUnit.assertNull;
2425

2526
public class DeprecateBuilderTest {
2627

28+
@GraphQLDeprecate("test field deprecated")
29+
public String testField;
30+
31+
@GraphQLDeprecate
32+
public String testField1;
33+
34+
public String testField2;
35+
2736
@GraphQLDeprecate("test deprecated")
2837
public int testMethod() {
2938
return 1;
@@ -56,7 +65,6 @@ public void build_graphQLDeprecateAnnotationExistsWithValue_returnAnnotationValu
5665
assertEquals(deprecate, "test deprecated");
5766
}
5867

59-
6068
@Test
6169
public void build_graphQLDeprecateAnnotationExistsWithNoValue_returnEmptyString() throws NoSuchMethodException {
6270
// arrange
@@ -95,4 +103,43 @@ public void build_noDeprecatedAnnotation_returnNull() throws NoSuchMethodExcepti
95103
// assert
96104
assertNull(deprecate);
97105
}
106+
107+
@Test
108+
public void build_deprecatedAnnotationDoesNotExistsOnField_returnNull() throws NoSuchFieldException {
109+
// arrange
110+
Field field = getClass().getField("testField2");
111+
DeprecateBuilder deprecateBuilder = new DeprecateBuilder(field);
112+
113+
// act
114+
String deprecate = deprecateBuilder.build();
115+
116+
// assert
117+
assertNull(deprecate);
118+
}
119+
120+
@Test
121+
public void build_graphQLDeprecateAnnotationExistsOnFieldWithNoValue_returnEmptyString() throws NoSuchFieldException {
122+
// arrange
123+
Field field = getClass().getField("testField1");
124+
DeprecateBuilder deprecateBuilder = new DeprecateBuilder(field);
125+
126+
// act
127+
String deprecate = deprecateBuilder.build();
128+
129+
// assert
130+
assertEquals(deprecate, "Deprecated");
131+
}
132+
133+
@Test
134+
public void build_graphQLDeprecateAnnotationExistsOnFieldWithValue_returnAnnotationValue() throws NoSuchFieldException {
135+
// arrange
136+
Field field = getClass().getField("testField");
137+
DeprecateBuilder deprecateBuilder = new DeprecateBuilder(field);
138+
139+
// act
140+
String deprecate = deprecateBuilder.build();
141+
142+
// assert
143+
assertEquals(deprecate, "test field deprecated");
144+
}
98145
}

0 commit comments

Comments
 (0)