Add FTP link to search dump#202
Draft
bilalebi wants to merge 12 commits into
Draft
Conversation
dpopleton
requested changes
May 1, 2026
dpopleton
left a comment
dpopleton
left a comment
Contributor
There was a problem hiding this comment.
This should be part of a much larger PR that encompasses all of the FTP strucuture changes.
I will start to work on it, but it needs:
FTP path updates (for the link on the sidebar)
JSON creation
and this.
We have another PR that included all of the work, but it was pre schema 3 and it is probably more work to migrate than to redo
… required Cause: GenomeAdaptor.get_public_path() used scalar_one_or_none() for variation/homology release lookup, but the DB can validly return multiple matching rows. Since search asks only for dataset_type="genebuild", those variation/homology lookups were unnecessary anyway. Changes made: - In genome.py (line 1115), variation/homology release lookup now only runs when dataset_type is all, variation, or homologies - Replaced scalar_one_or_none() with deterministic .order_by(EnsemblRelease.release_id.desc()).scalars().first()
# Conflicts: # src/ensembl/production/metadata/api/adaptors/genome.py # src/ensembl/production/metadata/api/exports/ftp_index.py # src/tests/test_api.py # src/tests/test_exports_json.py
… do. Needs verification for search and the ftp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I added
ftpfield to the search dumpHow?
The FTP URL itself is constructed using
accession,genebuild_annotation_sourceandlast_geneset_updateExample of how the field looks like for
Escherichia coli str. K-12 substr. MG1655 str. K12:Why?
It's needs to surface in the search results (last column in the screeshot below)
However
The URL generated will not work for now, I believe this will move to this new FTP structure in a later date
The example URL I based these changes on: