refactor: remove homeScreenName handling from manifest and related commands

- Eliminated homeScreenName management from the manifest and various commands, including add, init, pull, and push.
- Updated related tests to reflect the removal of homeScreenName assertions and ensure consistency in manifest structure.
- Simplified manifest options by removing unnecessary parameters related to homeScreenName.

Author: sharjeelyunus

README.md

@@ -110,7 +110,7 @@ ensemble update
 
 - **Manifest behavior**
   - For `widget`, `script`, `action`, and `translation`, `.manifest.json` is updated to include the new artifact.
-  - For the **first screen**, the CLI will offer to set it as `homeScreenName` in `.manifest.json`.
+  - Screens do not change `.manifest.json`.
 
 ## Usage
 

src/commands/add.ts

@@ -2,12 +2,11 @@ import fs from 'fs/promises';
 import path from 'path';
 import prompts from 'prompts';
 
-import { loadProjectConfig } from '../config/projectConfig.js';
-import { resolveAppContext } from '../config/projectConfig.js';
+import { loadProjectConfig, resolveAppContext } from '../config/projectConfig.js';
 import { getValidAuthSession } from '../auth/session.js';
 import { uploadAssetToStudio } from '../cloud/assetClient.js';
 import { upsertEnvConfig } from '../core/envConfig.js';
-import { upsertManifestEntry, type RootManifest } from '../core/manifest.js';
+import { upsertManifestEntry } from '../core/manifest.js';
 import { ui } from '../core/ui.js';
 import { withSpinner } from '../lib/spinner.js';
 
@@ -153,42 +152,6 @@ async function addAsset(
   };
 }
 
-async function maybeSetHomeScreenName(
-  projectRoot: string,
-  screenName: string,
-  interactive: boolean
-): Promise<boolean> {
-  const manifestPath = path.join(projectRoot, '.manifest.json');
-  let manifest: RootManifest = {};
-  try {
-    const raw = await fs.readFile(manifestPath, 'utf8');
-    manifest = JSON.parse(raw) as RootManifest;
-  } catch {
-    manifest = {};
-  }
-
-  if (manifest.homeScreenName && typeof manifest.homeScreenName === 'string') {
-    return false;
-  }
-
-  let shouldSet = true;
-  if (interactive) {
-    const { setHome } = await prompts({
-      type: 'confirm',
-      name: 'setHome',
-      message: `Set "${screenName}" as homeScreenName (no homeScreenName set yet)?`,
-      initial: true,
-    });
-    shouldSet = setHome === true;
-  }
-
-  if (!shouldSet) return false;
-
-  manifest.homeScreenName = screenName;
-  await fs.writeFile(manifestPath, JSON.stringify(manifest, null, 2) + '\n', 'utf8');
-  return true;
-}
-
 function screenTemplate(name: string): string {
   return `View:
   styles:
@@ -381,13 +344,10 @@ export async function addCommand(
     );
   }
 
-  const homeUpdated =
-    kind === 'screen' ? await maybeSetHomeScreenName(projectRoot, name, interactive) : false;
-
   ui.success(
     `Created ${kind} "${name}" at ${path.relative(
       projectRoot,
       filePath
-    )}${updateManifest ? ' and updated .manifest.json' : ''}${homeUpdated ? ' (set as homeScreenName)' : ''}.`
+    )}${updateManifest ? ' and updated .manifest.json' : ''}.`
   );
 }

src/commands/init.ts

@@ -1,5 +1,3 @@
-import fs from 'fs/promises';
-import path from 'path';
 import prompts from 'prompts';
 
 import { checkAppAccess, fetchRootScreenName } from '../cloud/firestoreClient.js';
@@ -58,23 +56,6 @@ export async function initCommand(): Promise<void> {
     description: access.app.description,
     ...(appHome !== undefined && { appHome }),
   });
-
-  if (appHome) {
-    const manifestPath = path.join(process.cwd(), '.manifest.json');
-    let manifest: Record<string, unknown> = {};
-    try {
-      const raw = await fs.readFile(manifestPath, 'utf8');
-      manifest = JSON.parse(raw) as Record<string, unknown>;
-    } catch {
-      manifest = {};
-    }
-
-    if (typeof manifest.homeScreenName !== 'string') {
-      manifest.homeScreenName = appHome;
-      await fs.writeFile(manifestPath, JSON.stringify(manifest, null, 2) + '\n', 'utf8');
-      ui.note(`Updated .manifest.json: homeScreenName set to "${appHome}".`);
-    }
-  }
   ui.success(`Initialized Ensemble config and linked alias "${alias}" to app "${appId}".`);
   ui.note(`You can now run \`ensemble push --app ${alias}\` or \`ensemble pull --app ${alias}\`.`);
 }

src/commands/pull.ts

@@ -17,11 +17,7 @@ import { resolveAppContext } from '../config/projectConfig.js';
 import { getValidAuthSession } from '../auth/session.js';
 import { withSpinner } from '../lib/spinner.js';
 import { applyCloudStateToFs } from '../core/applyToFs.js';
-import {
-  type RootManifest,
-  getCloudHomeScreenName,
-  type BuildManifestOptions,
-} from '../core/manifest.js';
+import { type RootManifest } from '../core/manifest.js';
 import { writeVerboseJson } from '../core/debugFiles.js';
 import { computePullPlan, type PullSummary } from '../core/sync.js';
 import { applyCloudAssetsToFs, buildEnvConfigForCloudAssets } from '../core/pullAssets.js';
@@ -324,41 +320,9 @@ export async function pullCommand(options: PullOptions = {}): Promise<void> {
     return;
   }
 
-  const appHome = appConfig.appHome as string | undefined;
-  const cloudHome = getCloudHomeScreenName(cloudApp);
-  const existingHome = manifestExisting.homeScreenName;
-  const hasHomeConflict =
-    typeof existingHome === 'string' && cloudHome && appHome && cloudHome !== appHome;
-
-  let manifestOptions: BuildManifestOptions = {
-    appHomeFromConfig: appHome,
-  };
-  if (hasHomeConflict && process.stdout.isTTY && process.stdin.isTTY) {
-    const choices: { title: string; value: string }[] = [
-      { title: `Keep current (${existingHome})`, value: existingHome },
-      ...(cloudHome && cloudHome !== existingHome
-        ? [{ title: `Use cloud (${cloudHome})`, value: cloudHome }]
-        : []),
-      ...(appHome && appHome !== existingHome
-        ? [{ title: `Use config appHome (${appHome})`, value: appHome }]
-        : []),
-    ].filter((c, i, a) => a.findIndex((x) => x.value === c.value) === i);
-
-    const { homeChoice } = await prompts({
-      type: 'select',
-      name: 'homeChoice',
-      message: `homeScreenName conflict: .manifest has "${existingHome}", cloud has "${cloudHome ?? 'none'}"${appHome ? `, ensemble.config.json appHome is "${appHome}"` : ''}. Choose:`,
-      choices,
-      initial: 0,
-    });
-    if (homeChoice !== undefined) {
-      manifestOptions = { ...manifestOptions, homeScreenNameOverride: homeChoice };
-    }
-  }
-
   await withSpinner('Writing local files...', async () => {
     await applyCloudStateToFs(projectRoot, cloudApp, localFiles, enabledByProp, {
-      manifestOptions,
+      manifestOptions: {},
       onProgress: (completed, total) => {
         // eslint-disable-next-line no-console
         console.log(`Writing files... (${completed}/${total})`);

src/commands/push.ts

@@ -20,7 +20,7 @@ import { getValidAuthSession } from '../auth/session.js';
 import { withSpinner } from '../lib/spinner.js';
 import { writeVerboseJson } from '../core/debugFiles.js';
 import { computePushPlan, type PushSummary, type PushCounts } from '../core/sync.js';
-import { buildAndWriteManifest, getCloudHomeScreenName } from '../core/manifest.js';
+import { buildAndWriteManifest } from '../core/manifest.js';
 import { ui } from '../core/ui.js';
 
 export interface PushOptions {
@@ -34,6 +34,11 @@ export interface PushOptions {
 
 const DESTRUCTIVE_CHANGE_PROMPT_THRESHOLD = 25;
 
+function getCloudHomeScreenName(cloudApp: CloudApp): string | undefined {
+  const screens = (cloudApp.screens ?? []).filter((s) => s.isArchived !== true);
+  return screens.find((s) => s.isRoot === true)?.name ?? screens[0]?.name;
+}
+
 /** Firestore/YAML artifact changes only (not asset uploads via studio function). */
 function yamlArtifactChangeTotal(summary: PushSummary): number {
   const k = summary.byKind;
@@ -448,13 +453,9 @@ export async function pushCommand(options: PushOptions = {}): Promise<void> {
 
       if (manifestNeedsRefresh && bundle) {
         // Only refresh manifest when artifact changes can affect its contents.
-        // Use appHome from config (what we pushed), not cloud's root.
         try {
           await withSpinner('Refreshing local manifest...', async () => {
-            await buildAndWriteManifest(root, bundle as CloudApp, {
-              appHomeFromConfig: appHome,
-              ...(appHome && { homeScreenNameOverride: appHome }),
-            });
+            await buildAndWriteManifest(root, bundle as CloudApp, {});
           });
         } catch (manifestErr) {
           if (verbose) {

src/commands/release.ts

@@ -373,10 +373,9 @@ export async function releaseUseCommand(options: ReleaseUseOptions = {}): Promis
     const snapshot = JSON.parse(snapshotJson) as CloudApp;
 
     const localFiles = await collectAppFiles(projectRoot);
-    const appHome = appConfig.appHome as string | undefined;
     await withSpinner('Writing local files...', () =>
       applyCloudStateToFs(projectRoot, snapshot, localFiles, enabledByProp, {
-        manifestOptions: { appHomeFromConfig: appHome },
+        manifestOptions: {},
         onProgress: (completed, total) => {
           if (total > 0 && completed % 25 === 0) {
             // eslint-disable-next-line no-console

src/core/manifest.ts

@@ -7,23 +7,11 @@ export type RootManifest = Record<string, unknown> & {
   scripts?: { name: string }[];
   widgets?: { name: string }[];
   actions?: { name: string }[];
-  homeScreenName?: string;
   defaultLanguage?: string;
   languages?: string[];
 };
 
-/** Get the screen name that cloud has as root (isRoot: true). */
-export function getCloudHomeScreenName(cloudApp: CloudApp): string | undefined {
-  const screens = (cloudApp.screens ?? []).filter((s) => s.isArchived !== true);
-  return screens.find((s) => s.isRoot === true)?.name ?? screens[0]?.name;
-}
-
-export interface BuildManifestOptions {
-  /** appHome from ensemble.config.json for the current app. */
-  appHomeFromConfig?: string;
-  /** When provided (e.g. from user prompt after conflict), use this value. Otherwise preserve existing if set. */
-  homeScreenNameOverride?: string;
-}
+export type BuildManifestOptions = Record<string, never>;
 
 /** Preserve existing manifest entries by name and order; only add minimal { name } for new ones. */
 function mergeByName<T extends { name: string }>(
@@ -50,7 +38,7 @@ export function buildManifestObject(
   cloudApp: CloudApp,
   options: BuildManifestOptions = {}
 ): RootManifest {
-  const { appHomeFromConfig, homeScreenNameOverride } = options;
+  void options;
 
   const cloudWidgetNames = (cloudApp.widgets ?? [])
     .filter((w) => w.isArchived !== true)
@@ -67,18 +55,6 @@ export function buildManifestObject(
     .map((a) => a.name);
   const actions = mergeByName(existing.actions, cloudActionNames);
 
-  const screens = (cloudApp.screens ?? []).filter((s) => s.isArchived !== true);
-  const cloudHome = screens.find((s) => s.isRoot === true)?.name ?? screens[0]?.name;
-
-  let homeScreenName: string | undefined;
-  if (homeScreenNameOverride) {
-    homeScreenName = homeScreenNameOverride;
-  } else if (typeof existing.homeScreenName === 'string') {
-    homeScreenName = existing.homeScreenName;
-  } else {
-    homeScreenName = appHomeFromConfig ?? cloudHome;
-  }
-
   const translations = (cloudApp.translations ?? []).filter((t) => t.isArchived !== true);
   const languages = translations.map((t) => t.name);
   const defaultLanguage =
@@ -91,7 +67,6 @@ export function buildManifestObject(
     widgets,
     scripts,
     actions,
-    ...(homeScreenName ? { homeScreenName } : {}),
     ...(languages.length > 0 ? { languages } : {}),
     ...(defaultLanguage ? { defaultLanguage } : {}),
   };

tests/commands/pushPull.test.ts

@@ -143,7 +143,6 @@ describe('push/pull integration (commands)', () => {
         {
           scripts: [],
           widgets: [],
-          homeScreenName: 'Home',
           defaultLanguage: 'ar',
           languages: ['ar', 'en'],
         },
@@ -483,13 +482,11 @@ describe('push/pull integration (commands)', () => {
     const manifest = JSON.parse(manifestRaw) as {
       widgets?: { name: string }[];
       scripts?: { name: string }[];
-      homeScreenName?: string;
       defaultLanguage?: string;
       languages?: string[];
     };
     expect(manifest.widgets?.some((w) => w.name === 'W1')).toBe(true);
     expect(manifest.scripts?.some((s) => s.name === 'S1')).toBe(true);
-    expect(manifest.homeScreenName).toBe('Home');
     expect(manifest.defaultLanguage).toBe('ar');
     expect(manifest.languages).toEqual(['ar', 'en']);
 

tests/core/applyToFs.test.ts

@@ -182,17 +182,21 @@ describe('applyCloudStateToFs', () => {
     };
 
     await applyCloudStateToFs(projectRoot, cloudApp, localFiles, allEnabled, {
-      manifestOptions: { appHomeFromConfig: 'Home' },
+      manifestOptions: {},
     });
 
     const manifestPath = path.join(projectRoot, '.manifest.json');
     const raw = await fs.readFile(manifestPath, 'utf8');
     const manifest = JSON.parse(raw) as {
-      homeScreenName?: string;
       scripts?: unknown[];
       widgets?: unknown[];
+      actions?: unknown[];
+      languages?: unknown[];
+      defaultLanguage?: unknown;
     };
-    expect(manifest.homeScreenName).toBe('Home');
+    expect(typeof manifest).toBe('object');
+    // Ensure it's valid JSON and a root object; specific fields are asserted elsewhere.
+    expect(Array.isArray(manifest.scripts ?? [])).toBe(true);
   });
 
   it('invokes onProgress every 25 completed tasks', async () => {