-
Notifications
You must be signed in to change notification settings - Fork 163
Add const shadows for forward mode AD on RegionBranchOpInterface
#2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vimarsh6739
wants to merge
1
commit into
main
Choose a base branch
from
scf.for-fix2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // RUN: %eopt --enzyme --split-input-file %s | FileCheck %s | ||
|
|
||
| module { | ||
| func.func @carry_mismatch_scf(%x : f64) -> f64 { | ||
| %zero = arith.constant 0.0 : f64 | ||
| %c0 = arith.constant 0 : index | ||
| %c1 = arith.constant 1 : index | ||
| %c10 = arith.constant 10 : index | ||
| %r = scf.for %i = %c0 to %c10 step %c1 iter_args(%acc = %zero) -> (f64) { | ||
| scf.yield %x : f64 | ||
| } | ||
| return %r : f64 | ||
| } | ||
|
|
||
| func.func @dcarry_mismatch_scf(%x : f64, %dx : f64) -> f64 { | ||
| %r = enzyme.fwddiff @carry_mismatch_scf(%x, %dx) { activity=[#enzyme<activity enzyme_dup>], ret_activity=[#enzyme<activity enzyme_dupnoneed>] } : (f64, f64) -> (f64) | ||
| return %r : f64 | ||
| } | ||
| } | ||
|
|
||
| // CHECK-LABEL: func.func private @fwddiffecarry_mismatch_scf( | ||
| // CHECK-DAG: %[[C0:.+]] = arith.constant 0 : index | ||
| // CHECK-DAG: %[[C1:.+]] = arith.constant 1 : index | ||
| // CHECK-DAG: %[[C10:.+]] = arith.constant 10 : index | ||
| // CHECK: %[[LOOP:.+]]:2 = scf.for %[[IV:.+]] = %[[C0]] to %[[C10]] step %[[C1]] iter_args(%[[ACC:.+]] = %{{.+}}, %[[DACC:.+]] = %{{.+}}) -> (f64, f64) { | ||
| // CHECK-NEXT: scf.yield %[[ARG0:.+]], %[[ARG1:.+]] : f64, f64 | ||
| // CHECK-NEXT: } | ||
| // CHECK-NEXT: return %[[LOOP]]#1 : f64 | ||
|
|
||
| // ----- | ||
|
|
||
| module { | ||
| func.func @carry_mismatch_affine(%x : f64) -> f64 { | ||
| %zero = arith.constant 0.0 : f64 | ||
| %r = affine.for %i = 0 to 10 iter_args(%acc = %zero) -> (f64) { | ||
| affine.yield %x : f64 | ||
| } | ||
| return %r : f64 | ||
| } | ||
|
|
||
| func.func @dcarry_mismatch_affine(%x : f64, %dx : f64) -> f64 { | ||
| %r = enzyme.fwddiff @carry_mismatch_affine(%x, %dx) { activity=[#enzyme<activity enzyme_dup>], ret_activity=[#enzyme<activity enzyme_dupnoneed>] } : (f64, f64) -> (f64) | ||
| return %r : f64 | ||
| } | ||
| } | ||
|
|
||
| // CHECK-LABEL: func.func private @fwddiffecarry_mismatch_affine( | ||
| // CHECK: %[[ALOOP:.+]]:2 = affine.for %[[AIV:.+]] = 0 to 10 iter_args(%[[AACC:.+]] = %{{.+}}, %[[ADACC:.+]] = %{{.+}}) -> (f64, f64) { | ||
| // CHECK-NEXT: affine.yield %[[ARG0:.+]], %[[ARG1:.+]] : f64, f64 | ||
| // CHECK-NEXT: } | ||
| // CHECK-NEXT: return %[[ALOOP]]#1 : f64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be here, but within the impl of createWithShadows, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it has to be here. We are shadowing only the const operands for any augmented newOp.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createWithShadows correctly adds const shadows. But newOp doesn't have them(since it was created with forceAugmentedReturns), so the takeBody() discards the args in the replacement op
We have 2 choices here - either add the const shadows to newOp or the replacement (after takeBody). The end result is the same.