Skip to content

economicEvents response type is missing period and comparison should allow null #12

@ThisIsSimmon

Description

@ThisIsSimmon

SDK version: 1.0.0
Runtime: Bun 1.3.8

Hi EODHD team,

I’m opening this issue here because I previously contacted support about this, but there has been no update for over a month.

In the Node.js/TypeScript SDK, the response data type for the economicEvents method appears to be missing the period field.

The actual API response includes a period field, but the SDK type definition does not include it, so TypeScript users cannot access it safely without casting or extending the type manually.

Additionally, in the same method, EconomicEventItem.comparison is currently typed as string, but the actual API response can return null.

Therefore, I believe the type should be updated from:

comparison: string;

to:

comparison: string | null;

Expected changes

  • Add the missing period field to the economicEvents response item type.
  • Update EconomicEventItem.comparison from string to string | null.

Current issue

EconomicEventItem.comparison // typed as string

But actual data can be:

comparison: null

Expected type

comparison: string | null

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions