refactor(tests): remove overengineered tests from test suite for improved clarity

Author: BinglanLi

BaseAgent/tests/test_nodes.py

@@ -16,24 +16,6 @@
 class TestRouting:
     """Tests for routing_function()."""
 
-    def test_routes_execute(self):
-        executor = NodeExecutor(make_agent())
-        state = make_state()
-        state["next_step"] = "execute"
-        assert executor.routing_function(state) == "execute"
-
-    def test_routes_generate(self):
-        executor = NodeExecutor(make_agent())
-        state = make_state()
-        state["next_step"] = "generate"
-        assert executor.routing_function(state) == "generate"
-
-    def test_routes_end(self):
-        executor = NodeExecutor(make_agent())
-        state = make_state()
-        state["next_step"] = "end"
-        assert executor.routing_function(state) == "end"
-
     def test_raises_on_unknown(self):
         executor = NodeExecutor(make_agent())
         state = make_state()
@@ -45,16 +27,6 @@ def test_raises_on_unknown(self):
 class TestRoutingSelfCritic:
     """Tests for routing_function_self_critic()."""
 
-    def test_generate(self):
-        executor = NodeExecutor(make_agent())
-        state = {"next_step": "generate"}
-        assert executor.routing_function_self_critic(state) == "generate"
-
-    def test_end(self):
-        executor = NodeExecutor(make_agent())
-        state = {"next_step": "end"}
-        assert executor.routing_function_self_critic(state) == "end"
-
     def test_raises_on_unknown(self):
         executor = NodeExecutor(make_agent())
         state = {"next_step": "bad"}

BaseAgent/tests/test_repl_isolation.py

@@ -40,10 +40,6 @@ def test_global_namespace_unchanged_when_ns_provided(self):
         run_python_repl("_isolation_probe = 'hello'", namespace=ns)
         assert "_isolation_probe" not in _persistent_namespace
 
-    def test_global_namespace_used_when_none(self, clear_repl_namespace):
-        run_python_repl("_global_test_var = 99")
-        assert _persistent_namespace.get("_global_test_var") == 99
-
     def test_variables_persist_across_calls_in_same_namespace(self):
         ns = {}
         run_python_repl("counter = 0", namespace=ns)
@@ -117,10 +113,6 @@ def test_global_namespace_unchanged_when_ns_provided(self):
         inject_custom_functions_to_repl({"_probe_fn": lambda: None}, namespace=ns)
         assert "_probe_fn" not in _persistent_namespace
 
-    def test_inject_into_global_when_namespace_none(self, clear_repl_namespace):
-        inject_custom_functions_to_repl({"_global_fn": lambda: 42})
-        assert "_global_fn" in _persistent_namespace
-
     def test_empty_functions_dict_is_noop(self):
         ns = {}
         inject_custom_functions_to_repl({}, namespace=ns)

BaseAgent/tests/test_resource_manager.py

@@ -96,28 +96,6 @@ def test_add_tool_ignores_existing_id(self):
         rm.add_tool(t)
         assert t.id == 0
 
-    def test_get_tool_by_name_found(self):
-        rm = ResourceManager()
-        rm.add_tool(make_tool("search_tool"))
-        tool = rm.get_tool_by_name("search_tool")
-        assert tool is not None
-        assert tool.name == "search_tool"
-
-    def test_get_tool_by_name_not_found(self):
-        rm = ResourceManager()
-        assert rm.get_tool_by_name("ghost") is None
-
-    def test_find_tool_by_id_found(self):
-        rm = ResourceManager()
-        rm.add_tool(make_tool("my_func"))
-        tool = rm.find_tool_by_id(0)
-        assert tool is not None
-        assert tool.name == "my_func"
-
-    def test_find_tool_by_id_not_found(self):
-        rm = ResourceManager()
-        assert rm.find_tool_by_id(999) is None
-
     def test_get_tool_id_by_name(self):
         rm = ResourceManager()
         rm.add_tool(make_tool("alpha"))
@@ -129,10 +107,6 @@ def test_get_tool_name_by_id(self):
         rm.add_tool(make_tool("gamma"))
         assert rm.get_tool_name_by_id(0) == "gamma"
 
-    def test_get_tool_name_by_id_not_found(self):
-        rm = ResourceManager()
-        assert rm.get_tool_name_by_id(42) is None
-
     def test_list_all_tools(self):
         rm = ResourceManager()
         rm.add_tool(make_tool("t1"))
@@ -149,21 +123,13 @@ def test_remove_tool_by_id_success(self):
         assert removed is True
         assert rm.get_tool_by_name("removeme") is None
 
-    def test_remove_tool_by_id_not_found(self):
-        rm = ResourceManager()
-        assert rm.remove_tool_by_id(999) is False
-
     def test_remove_tool_by_name_success(self):
         rm = ResourceManager()
         rm.add_tool(make_tool("byname"))
         removed = rm.remove_tool_by_name("byname")
         assert removed is True
         assert rm.get_tool_by_name("byname") is None
 
-    def test_remove_tool_by_name_not_found(self):
-        rm = ResourceManager()
-        assert rm.remove_tool_by_name("ghost") is False
-
     def test_filter_tools_by_module(self):
         rm = ResourceManager()
         rm.add_tool(make_tool("a", module="pkg.utils"))
@@ -197,40 +163,13 @@ def test_load_tools_bulk(self):
 
 class TestDataManagement:
 
-    def test_add_data_item(self):
-        rm = ResourceManager()
-        rm.add_data_item(make_data("proteins.parquet", "parquet"))
-        assert len(rm.collection.data_lake) == 1
-
-    def test_add_custom_data(self):
-        rm = ResourceManager()
-        rm.add_custom_data(make_custom_data("exp.csv"))
-        assert len(rm.collection.custom_data) == 1
-
     def test_get_all_data_combines_both(self):
         rm = ResourceManager()
         rm.add_data_item(make_data("lake.tsv", "tsv"))
         rm.add_custom_data(make_custom_data("custom.csv"))
         all_data = rm.get_all_data()
         assert len(all_data) == 2
 
-    def test_find_data_by_filename_data_lake(self):
-        rm = ResourceManager()
-        rm.add_data_item(make_data("binding.tsv"))
-        item = rm.find_data_by_filename("binding.tsv")
-        assert item is not None
-        assert item.filename == "binding.tsv"
-
-    def test_find_data_by_filename_custom_data(self):
-        rm = ResourceManager()
-        rm.add_custom_data(make_custom_data("myexp.csv"))
-        item = rm.find_data_by_filename("myexp.csv")
-        assert item is not None
-
-    def test_find_data_by_filename_not_found(self):
-        rm = ResourceManager()
-        assert rm.find_data_by_filename("missing.csv") is None
-
     def test_filter_data_by_category(self):
         rm = ResourceManager()
         rm.add_data_item(make_data("a.csv", category="genomics"))
@@ -266,33 +205,12 @@ def test_load_data_items_bulk(self):
 
 class TestLibraryManagement:
 
-    def test_add_library(self):
-        rm = ResourceManager()
-        rm.add_library(make_library("pandas"))
-        assert len(rm.collection.libraries) == 1
-
-    def test_add_custom_software(self):
-        rm = ResourceManager()
-        rm.add_custom_software(make_custom_software("blast"))
-        assert len(rm.collection.custom_software) == 1
-
     def test_get_all_libraries_combines_both(self):
         rm = ResourceManager()
         rm.add_library(make_library("biopython"))
         rm.add_custom_software(make_custom_software("blast"))
         assert len(rm.get_all_libraries()) == 2
 
-    def test_find_library_by_name(self):
-        rm = ResourceManager()
-        rm.add_library(make_library("scipy"))
-        lib = rm.find_library_by_name("scipy")
-        assert lib is not None
-        assert lib.name == "scipy"
-
-    def test_find_library_by_name_not_found(self):
-        rm = ResourceManager()
-        assert rm.find_library_by_name("ghost") is None
-
     def test_filter_libraries_by_type(self):
         rm = ResourceManager()
         rm.add_library(make_library("numpy", "Python"))

BaseAgent/tests/test_skills.py

@@ -48,44 +48,6 @@ def write_skill_file(path: Path, frontmatter: str, body: str = "## Instructions\
 # ==============================================================================
 
 class TestSkillModel:
-    def test_required_fields(self):
-        skill = Skill(name="my-skill", description="does stuff")
-        assert skill.name == "my-skill"
-        assert skill.description == "does stuff"
-
-    def test_defaults(self):
-        skill = make_skill()
-        assert skill.tools == []
-        assert skill.instructions == "## Instructions\nDo the thing."
-        assert skill.source_path is None
-        assert skill.source_dir is None
-        assert skill.selected is True
-
-    def test_tools_list(self):
-        skill = make_skill(tools=["run_python_repl", "read_function_source_code"])
-        assert "run_python_repl" in skill.tools
-
-    def test_missing_name_raises(self):
-        with pytest.raises(Exception):
-            Skill(description="no name")
-
-    def test_missing_description_raises(self):
-        with pytest.raises(Exception):
-            Skill(name="no-desc")
-
-    def test_selected_flag(self):
-        skill = make_skill(selected=False)
-        assert skill.selected is False
-
-    def test_resource_collection_has_skills(self):
-        rc = ResourceCollection()
-        assert hasattr(rc, "skills")
-        assert rc.skills == []
-
-    def test_source_dir_default(self):
-        skill = make_skill()
-        assert skill.source_dir is None
-
     def test_has_bundled_resources_no_source_dir(self):
         skill = make_skill()
         assert skill.has_bundled_resources is False
@@ -123,27 +85,18 @@ def test_add_skill(self):
         assert len(self.rm.get_all_skills()) == 1
         assert self.rm.get_all_skills()[0].name == "alpha"
 
-    def test_get_all_skills_empty(self):
-        assert self.rm.get_all_skills() == []
-
     def test_get_skill_by_name(self):
         skill = make_skill(name="beta")
         self.rm.add_skill(skill)
         found = self.rm.get_skill_by_name("beta")
         assert found is not None
         assert found.name == "beta"
 
-    def test_get_skill_by_name_missing(self):
-        assert self.rm.get_skill_by_name("nope") is None
-
     def test_remove_skill_by_name(self):
         self.rm.add_skill(make_skill(name="gamma"))
         assert self.rm.remove_skill_by_name("gamma") is True
         assert self.rm.get_skill_by_name("gamma") is None
 
-    def test_remove_skill_by_name_missing(self):
-        assert self.rm.remove_skill_by_name("nope") is False
-
     def test_get_selected_skills(self):
         self.rm.add_skill(make_skill(name="s1", selected=True))
         self.rm.add_skill(make_skill(name="s2", selected=False))