Update GetRankInGroup to GetRankInGroupAsync#54
Open
ImFirstPlace wants to merge 1 commit into
Open
Conversation
ImFirstPlace
commented
Dec 22, 2025
ImFirstPlace
commented
Contributor
- Update GetRankInGroup to GetRankInGroupAsync
Member
|
WHat |
coasterteam
requested changes
Feb 6, 2026
coasterteam
left a comment
coasterteam
left a comment
Contributor
There was a problem hiding this comment.
If we're going to update this, might as well do a little improvement alongside it.
| local plr = Players:GetPlayerByUserId(textSource.UserId) | ||
|
|
||
| if plr:IsInGroup(GroupID) and plr:GetRankInGroup(GroupID) == RankID then | ||
| if plr:IsInGroup(GroupID) and plr:GetRankInGroupAsync(GroupID) == RankID then |
Contributor
There was a problem hiding this comment.
We should probably wrap these in a pcall that won't break the script should it decides to error.
| if localplayer:IsInGroup(group) then | ||
| for _, v in pairs(ranks) do | ||
| if localplayer:GetRankInGroup(group) == v then | ||
| if localplayer:GetRankInGroupAsync(group) == v then |
Contributor
There was a problem hiding this comment.
Same comment here, wrap the Async method inside a pcall
Contributor
There was a problem hiding this comment.
Ditch the IsInGroup check in my opinion, pcall the GetRankInGroupAsync method prior to the loop and cache the rank value in a variable; default to 0 if it doesn't succeed of course, go from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.