`:rainbowify` and multiple other commands are broken

[ccuser44]

Version channel

Nightly

Loader version

276

What part of Adonis is this related to?

Command

What happened?

:rainbowify and multiple other commands are broken that create scripts

Steps to reproduce

1. Run :rainbowify

Device

Windows

Relevant log output

[feme12]

I looked into it and for some reason I believe the code for rainbowify client script is not actually running.

[thatgato]

I've looked into this aswell, and it goes a bit deeper than I thought

Since I'm a first time contributor, I don't know the ins and outs of this project, but here is what I found:

Issue 1:

local execute = script:FindFirstChild("Execute")
local code, loadCode = rawget(_G, "Adonis").Scripts.ExecutePermission(script, execute and execute.Value)
local env = getfenv()

warn(script.ClassName)
print(execute)
print(code)
print(loadCode)
print(env)
if code then
	loadCode(code, env)()
end

This is the base client script that Adonis creates for commands like :rainbowify
I added the warn and print instructions for debugging
The class name is "Script" even though it is a local script
Also, code and loadCode are both nil, so the code will never be ran.

Issue 2:

The clientside Core script:
On line 300, there is this piece of code:

end, true, { t.instanceOf("LocalScript"), t.string });

the t.instanceOf("LocalScript") seems to fail.
changing it to t.InstanceIsA("Script") fixes the problem (but this likely shouldn't be done in production)

With these changes, we get to issue 3

Issue 3:

Now the code runs halfway, then crashes inside of FiOne with this message: .Shared.FiOne:407: invalid argument #1 to 'fromstring' (string expected, got nil)

This is how far I got so far
It looks like a bytecode issue, or something else with FiOne right now, but I'll try to get deeper into this bug somewhen in the future

Sidenote:

The player's clothes get completely removed. Since the command isn't working, this functionality should probably be disabled, becauseI'm pretty sure stripping a roblox character from its clothes would go against the Roblox ToS. (See MainModule\Server\Commands\Fun.luau for the Rainbowify command implementation at line 650 for more info.)