Attempt to fix sandboxing bricking Adonis#2129
Open
ccuser44 wants to merge 27 commits into
Open
Conversation
Added InternalSandboxError function to handle sandbox error notice and remove sandbox if possible.
Added RemoveSandbox function to manage security capabilities.
Updated error message to include instructions for enabling settings.
Added instructions for disabling the .Sandboxed property and enabling 'Load Third Party Assets'.
Added instructions for resolving script loading issues with Adonis.
Added a user notice for potential loader issues related to Adonis Loader's script sandboxing. Included instructions on how to disable sandboxing for better functionality.
Added a new script to assist with loader related issues, including functionality for cloning and managing a debug helper.
Add additional conditions for debugHelper activation based on sandboxed states.
Contributor
Author
|
Okay this is ready now @joritochip @Sceleratis @Expertcoderz @Dimenpsyonal @GalacticInspired |
- Prevent loader failing due to mutex creation - Prevent loader failing due to useless backup
Contributor
Author
|
Note: The plugin functionality is not enabled because the server plugin requiring is not currently handled by the loader (but that should be done as part of a seperate PoF) Outside of this PR both of the following PRs #1905 and #2018 (yes even the panic mode, no it wasn't a meme) were created partially or fully due to in mind with exactly these script capabilities when some capabilities are partially unavailable. |
Contributor
Author
|
An update regarding sandboxing. https://devforum.roblox.com/t/protect-your-games-with-script-capabilities-sandboxing/4634642 Roblox will start enforcing sandbox restrictions on the toolbox so this will be needed sooner or later. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix loader sandboxing related issues. (Should largely fix sandboxing related issues unless script execution is totally disabled)