Fixes and modifcations to several fun commands#2106
Conversation
ostrichman1
changed the title
|
It looks like the coloring script for :rainbowify is client-sided, so only the player the command was used on can see the rainbow colors. It doesn't make sense to remove the clothes of the player on the server, just for the colors to not be replicated. I understand that this appears to of been the previous behavior as well, but it looks like it may of been unintentional. |
|
Rainbowify shouldn't be broken in the first place. There is some fundamental issue preventing any string scripts from running |
| local scr = Core.NewScript("ClientScript", [[ | ||
| local restore = {} | ||
| local tween = game:GetService("TweenService") | ||
|
|
||
| repeat | ||
| task.wait() | ||
| local char = script.Parent.Parent | ||
| local clr = BrickColor.random() | ||
| for i, v in next, char:GetChildren() do | ||
| if v:IsA("BasePart") and v.Name ~= "HumanoidRootPart" then | ||
| if not restore[v] then | ||
| restore[v] = v.Color | ||
| end | ||
| v.Color = Color3.fromHSV(os.clock() % 1, 1, 1) | ||
| end | ||
| end | ||
| until not char or script.Name == "Stop" -- signal to unrainbowify | ||
|
|
||
| if script.Name == "Stop" then | ||
| for item, clr in next, restore do | ||
| item.Color = clr -- restore old colors | ||
| end | ||
| script:Destroy() | ||
| end | ||
| ]], true) | ||
| scr.Name = "Rainbowify" |
There was a problem hiding this comment.
There is a fundamental issue preventing string scripts from running in the first place which I think should be investigated. Also changing this to a localscript makes it only visible to the current user.
There was a problem hiding this comment.
If you want to investigate that feel free to but I don't have a clue 🤷♂️
| Admin.RunCommand(`{Settings.Prefix}pants`, v.Name, "233373970") | ||
| Admin.RunCommand(`{Settings.Prefix}shirt`, v.Name, "133078195") | ||
| for _, v in v.Character:GetChildren() do | ||
| if v.Name == "Shirt" then local cl = v:Clone() cl.Parent = v.Parent cl.ShirtTemplate = "http://www.roblox.com/asset/?id=133078195" v:Destroy() end | ||
| if v.Name == "Pants" then local cl = v:Clone() cl.Parent = v.Parent cl.PantsTemplate = "http://www.roblox.com/asset/?id=233373970" v:Destroy() end | ||
| end |
There was a problem hiding this comment.
This is definitely a problem but I think you should attempt to fix it some other way because runcommand supports humanoiddescriptions and is more terse and modular.
There was a problem hiding this comment.
This seems to not work because of the fact that they are not clothing ids but instead asset ids to a shirt template and results in "Item not supported"
There was a problem hiding this comment.
I found the real ID for the pants so you can use the runcommand for the pants 233373971
I've looked into this specifically, and posted my findings so far under issue #2090 |
|
What is happening? I only stated that it works only on the client, not that it doesn't work at all. |
It currently does not work and the fix in the pr is kind of a hacky fix. There's a deeper issue |
4 participants
Fixed some broken fun commands
:glitch - Requires intensity to be a value above 0
:ghostglitch - Requires intensity to be a value above 0
:vibrate - Requires intensity to be a value above 0
:clown - Place was taken down so the command just kicks the player now
:material - Made it work when no material argument is given, checks material exists (PoF attached)
:neon - Remove unnecessary "(optional)" from argument for colour
:forest - Add permission check hints to command
:rainbowify - Fixes command by moving script to assets (PoF attached)
:shrek - Fixed shirt and pants not showing (PoF attached)
:freefall - Add default height
:stickman - Works with R15 characters (PoF attached)
:dog - Fixed R15 support (PoF attached - R6 attached for reference)
:flatten - Remove unnecessary "optional" from argument for number
:oldflatten - Remove unnecessary "optional" from argument for number