Skip to content

Commit 57ad2d6

Browse files
committed
Renamed ServerResponse to MockResponse for consistency with request.
Simplified responses by removing unused argument.
1 parent 48ca90b commit 57ad2d6

6 files changed

Lines changed: 11 additions & 18 deletions

File tree

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/server/MockDispatcher.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class MockDispatcher :
3333
override fun dispatch(request: RecordedRequest): MockResponse {
3434
val endPoint = request.path!!.substringBefore("?")
3535
usedEndpoints.add(endPoint)
36-
val response = responses[endPoint]?.mockResponse(this) ?: ServerResponse(code = 404)
36+
val response = responses[endPoint]?.mockResponse() ?: MockResponse(code = 404)
3737
return if (response.upgradeToWebSocket) {
3838
MockResponse().withWebSocketUpgrade(
3939
object : WebSocketListener() {

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/server/ServerResponse.kt renamed to architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/server/MockResponse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.mitteloupe.whoami.test.server
22

3-
data class ServerResponse(
3+
data class MockResponse(
44
val upgradeToWebSocket: Boolean = false,
55
val code: Int = 200,
66
val headers: List<Pair<String, String>> = emptyList(),
Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
package com.mitteloupe.whoami.test.server.response
22

3-
import com.mitteloupe.whoami.test.server.ResponseBinder
4-
import com.mitteloupe.whoami.test.server.ServerResponse
3+
import com.mitteloupe.whoami.test.server.MockResponse
54

65
sealed class ErrorResponse {
76
object NotFound : MockResponseContents {
8-
override fun mockResponse(responseBinder: ResponseBinder) = ServerResponse(
9-
code = 404
10-
)
7+
override fun mockResponse() = MockResponse(code = 404)
118
}
129
}
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package com.mitteloupe.whoami.test.server.response
22

3-
import com.mitteloupe.whoami.test.server.ResponseBinder
4-
import com.mitteloupe.whoami.test.server.ServerResponse
3+
import com.mitteloupe.whoami.test.server.MockResponse
54

65
interface MockResponseContents {
7-
fun mockResponse(responseBinder: ResponseBinder): ServerResponse
6+
fun mockResponse(): MockResponse
87
}
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
package com.mitteloupe.whoami.test.server.response
22

3-
import com.mitteloupe.whoami.test.server.ResponseBinder
4-
import com.mitteloupe.whoami.test.server.ServerResponse
3+
import com.mitteloupe.whoami.test.server.MockResponse
54

65
class SequenceResponse(private vararg val responses: MockResponseContents) : MockResponseContents {
76
private var responseIndex = 0
8-
override fun mockResponse(responseBinder: ResponseBinder): ServerResponse {
7+
override fun mockResponse(): MockResponse {
98
val mockResponse = responses[responseIndex]
109
responseIndex++
1110
if (responseIndex == responses.size) {
1211
responseIndex = 0
1312
}
14-
return mockResponse.mockResponse(responseBinder)
13+
return mockResponse.mockResponse()
1514
}
1615
}

architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/server/response/SimpleResponse.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package com.mitteloupe.whoami.test.server.response
22

33
import com.mitteloupe.whoami.test.asset.assetReader
4-
import com.mitteloupe.whoami.test.server.ResponseBinder
5-
import com.mitteloupe.whoami.test.server.ServerResponse
4+
import com.mitteloupe.whoami.test.server.MockResponse
65

76
data class SimpleResponse(
87
private val code: Int = 200,
@@ -17,6 +16,5 @@ data class SimpleResponse(
1716
}
1817
}
1918

20-
override fun mockResponse(responseBinder: ResponseBinder) =
21-
ServerResponse(code = code, headers = headers, body = body)
19+
override fun mockResponse() = MockResponse(code = code, headers = headers, body = body)
2220
}

0 commit comments

Comments
 (0)