Skip to content

Removed redundant lazy. #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EranBoudjnah merged 5 commits into from
Apr 6, 2025
Merged

Removed redundant lazy. #392

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ef2036
Unified and simplified UI tests.
EranBoudjnah Apr 5, 2025
09076a7
Merge branch 'master' of github.com:EranBoudjnah/CleanArchitectureFor…
EranBoudjnah Apr 6, 2025
abf43bc
Merge branch 'master' of github.com:EranBoudjnah/CleanArchitectureFor…
EranBoudjnah Apr 6, 2025
499ceaa
Removed redundant lazy.
EranBoudjnah Apr 6, 2025
d4bdd80
Made composeTestRule protected.
EranBoudjnah Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions architecture/instrumentation-test/src/main/java/com/mitteloupe/whoami/test/test/BaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,23 @@ abstract class BaseTest {
@Inject
lateinit var composeIdlingResources: @JvmSuppressWildcards Collection<ComposeIdlingResource>

private val webServerRule by lazy {
WebServerRule(
lazy { listOf(mockDispatcher) },
lazy { responseStore }
) { mockWebServerProvider.serverUrl }
}
private val webServerRule = WebServerRule(
lazy { listOf(mockDispatcher) },
lazy { responseStore }
) { mockWebServerProvider.serverUrl }

private val localStoreRule by lazy {
LocalStoreRule(
lazy { sharedPreferences },
lazy { keyValueStore }
)
}
private val localStoreRule = LocalStoreRule(
lazy { sharedPreferences },
lazy { keyValueStore }
)

protected abstract val composeTestRule: ComposeContentTestRule

abstract val composeTestRule: ComposeContentTestRule
@SuppressLint("UnsafeOptInUsageError")
private val grantPermissionRule = SdkAwareGrantPermissionRule.grant(WRITE_EXTERNAL_STORAGE)

@get:Rule
val testRules: RuleChain by lazy {
@SuppressLint("UnsafeOptInUsageError")
val grantPermissionRule = SdkAwareGrantPermissionRule.grant(
WRITE_EXTERNAL_STORAGE
)
RuleChain
.outerRule(hiltAndroidRule)
.around(DisableAnimationsRule())
Expand Down