Skip to content

Removed repetition in DisableAnimationsRule. #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EranBoudjnah merged 2 commits into from
Apr 8, 2025
Merged

Removed repetition in DisableAnimationsRule. #395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a8d618
Removed repetition in DisableAnimationsRule.
EranBoudjnah Apr 7, 2025
757ae2e
Improved naming, reduced indentation.
EranBoudjnah Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 25 additions & 31 deletions ...strumentation-test/src/main/java/com/mitteloupe/whoami/test/rule/DisableAnimationsRule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,58 +7,52 @@ import org.junit.rules.TestRule
import org.junit.runner.Description
import org.junit.runners.model.Statement

private val animationKeys = setOf(
"transition_animation_scale",
"window_animation_scale",
"animator_duration_scale"
)

private const val DEFAULT_SCALE = 1f

class DisableAnimationsRule : TestRule {
private var transitionAnimationScale: Float = 0f
private var windowAnimationScale: Float = 0f
private var animatorDurationScale: Float = 0f
private val savedScaleValues = mutableMapOf<String, Float>()
private val device: UiDevice
get() = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation())

override fun apply(base: Statement, description: Description): Statement =
object : Statement() {
@Throws(Throwable::class)
override fun evaluate() {
disableAnimations()
saveAndDisableAnimations()
try {
base.evaluate()
} finally {
enableAnimations()
restoreAnimations()
}
}
}

@Throws(IOException::class)
private fun disableAnimations() {
UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()).apply {
transitionAnimationScale =
executeShellCommand("settings get global transition_animation_scale")
.orDefault().toFloat()
windowAnimationScale =
executeShellCommand("settings get global window_animation_scale")
.orDefault().toFloat()
animatorDurationScale =
executeShellCommand("settings get global animator_duration_scale")
.orDefault().toFloat()
executeShellCommand("settings put global transition_animation_scale 0")
executeShellCommand("settings put global window_animation_scale 0")
executeShellCommand("settings put global animator_duration_scale 0")
private fun saveAndDisableAnimations() {
animationKeys.forEach { key ->
savedScaleValues[key] =
device.executeShellCommand("settings get global $key").orDefault()
device.executeShellCommand("settings put global $key 0")
}
}

@Throws(IOException::class)
private fun enableAnimations() {
UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()).apply {
executeShellCommand(
"settings put global transition_animation_scale $transitionAnimationScale"
)
executeShellCommand("settings put global window_animation_scale $windowAnimationScale")
executeShellCommand(
"settings put global animator_duration_scale $animatorDurationScale"
)
private fun restoreAnimations() {
animationKeys.forEach { key ->
val savedValue = savedScaleValues[key] ?: DEFAULT_SCALE
device.executeShellCommand("settings put global $key $savedValue")
}
}

private fun String.orDefault() = if (isEmpty() || trim() == "null") {
"1"
private fun String?.orDefault() = if (isNullOrEmpty() || trim() == "null") {
DEFAULT_SCALE
} else {
this
toFloat()
}
}