Appending mangledNameHash to AstNode identifier. (#438)

Author: intjftw

plugins/cpp/model/include/model/cppastnode.h

@@ -183,6 +183,7 @@ inline std::uint64_t createIdentifier(const CppAstNode& astNode_)
 
   res
     .append(astNode_.astValue).append(":")
+    .append(std::to_string(astNode_.mangledNameHash)).append(":")
     .append(std::to_string(
       static_cast<SymbolTypeInt>(astNode_.symbolType))).append(":")
     .append(std::to_string(

plugins/cpp/test/src/cppparsertest.cpp

@@ -357,10 +357,11 @@ TEST_F(CppParserTest, Record)
       {
         case -1: 
           EXPECT_TRUE(
-            // Compiler generated assignment operator return value.
-            n.astType == model::CppAstNode::AstType::ReturnTypeLoc ||
-            // TODO: What's this? Maybe a compiler generated copy constructor
-            // parameter's type? Then why isn't this a ParameterTypeLoc?
+          // TODO: investigate the type of this. It is possibly the parameter of a
+          // compiler generated copy constructor or assignment operator.
+          // The type should also be visible as a return type of the compiler generated
+          // assignment operator.
+            n.astType == model::CppAstNode::AstType::ParameterTypeLoc ||
             n.astType == model::CppAstNode::AstType::TypeLocation);
           break;