Skip to content

Fix Thrift usage in the C++ LSP plugin#708

Merged
intjftw merged 1 commit into
Ericsson:masterfrom
mcserep:fix-lsp-thrift
Feb 4, 2024
Merged

Fix Thrift usage in the C++ LSP plugin#708
intjftw merged 1 commit into
Ericsson:masterfrom
mcserep:fix-lsp-thrift

Conversation

@mcserep

@mcserep mcserep commented Feb 4, 2024

Copy link
Copy Markdown
Collaborator

Include Thrift headers and link it to the C++ LSP plugin.

Fixes bug introduced by #599.

@mcserep mcserep added Kind: Bug ⚠️ Target: LSP Issues related to Language Server Protocol (LSP)-based operation, as opposed to the Web app. labels Feb 4, 2024
@mcserep mcserep added this to the Release Gershwin milestone Feb 4, 2024
@mcserep mcserep requested a review from intjftw February 4, 2024 10:42
@mcserep mcserep self-assigned this Feb 4, 2024
@mcserep

mcserep commented Feb 4, 2024

Copy link
Copy Markdown
Collaborator Author

This PR fixed the issue, it is again the out of disk issue during parsing. Seems like #707 was not a sufficient fix, we were just lucky, that the CI passed that time.

@intjftw intjftw merged commit 962d01d into Ericsson:master Feb 4, 2024
@mcserep mcserep deleted the fix-lsp-thrift branch February 4, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind: Bug ⚠️ Target: LSP Issues related to Language Server Protocol (LSP)-based operation, as opposed to the Web app.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants