[fix] Personal access token name fix#4628
Merged
bruntib merged 1 commit intoEricsson:masterfrom Jul 10, 2025
Merged
Conversation
Until now a random string was generated as a personal access token name in the schema upgrade script that copies auth session tokens to the personal_access_tokens table. In rare cases the random generator could return the same random string twice. For this reason in PostgreSQL an incremental integer is used instead of the random name. Until now all auth session tokens became a personal access token. From now only the "can_expire = false" tokens become personal access tokens.
Szelethus
approved these changes
Jul 10, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
An exquisite execution of software enginnering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now a random string was generated as a personal access token name in the schema upgrade script that copies auth session tokens to the personal_access_tokens table. In rare cases the random generator could return the same random string twice. For this reason in PostgreSQL an incremental integer is used instead of the random name.
Until now all auth session tokens became a personal access token. From now only the "can_expire = false" tokens become personal access tokens.