Rework config_directory#4645
Merged
bruntib merged 1 commit intoEricsson:masterfrom Aug 15, 2025
Merged
Conversation
barnabasdomozi
added
CLI 💻
barnabasdomozi
force-pushed
the
config_directory_rework
branch
2 times, most recently
from
89a72aa to
b0f6e74
Compare
barnabasdomozi
force-pushed
the
config_directory_rework
branch
3 times, most recently
from
cd76656 to
9c53e2b
Compare
bruntib
requested changes
Aug 12, 2025
Contributor
bruntib
left a comment
bruntib
left a comment
There was a problem hiding this comment.
Please, write a short description in the commit message about the motivation of this change. Thank you!
| LOG.debug("Initializing HTTP server...") | ||
|
|
||
| self.config_directory = config_directory | ||
| self.workspace_directory = workspace_directory |
Contributor
There was a problem hiding this comment.
Why does this class need the workspace directory?
Collaborator
Author
There was a problem hiding this comment.
It is used by the ThriftProductHandler class, for example on line 297 in file product_server.py.
Currently, --config-directory and --workspace parameters are essentially the same for CodeChecker server. The new behaviour is to have a separate config directory where configuration files and SSL certs are stored, while SQLite databases, server logs and temporary files remain in the workspace directory. To remain compatible, if --config-directory is not specified, it will be the same as --workspace.
barnabasdomozi
force-pushed
the
config_directory_rework
branch
from
9c53e2b to
ce73536
Compare
Collaborator
Author
bruntib
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I reworked
--config-directoryand--workspacesettings. The current behavior is that these parameters are essentially the same.PR changes:
Server configuration files and SSL certs are now stored in
--config-directory, while SQLite databases, logs, temporary files in--workspace.If
--config-directoryis not set, it will be the same as--workspace.For the review:
args.dbdatadirwas also removed since I haven't found any usage of that in the entire codebase.