Skip to content

Add runName save to backend for filter loading. #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feyruzb wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −1
Open

Add runName save to backend for filter loading. #4822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06b984f
feat(backend): add runName save to backend for filter loading
feyruzb Apr 16, 2026
182c9f6
chore: rename saved object for clarity
feyruzb Apr 16, 2026
a598f0f
fix: reduce line length
feyruzb Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion web/server/vue-cli/src/components/Report/ReportFilter/ReportFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,14 +635,24 @@ export default {
},

saveCurrentFilter(mode) {

// this.reportFilter.runName is left empty during normal UI interaction,
// as it is a deprecated field. At save time, the `runName` is manually
// inserted into a clone of `reportFilter`. On component load, it's put
// back into URL query, where component fetches it from.
const presetReportFilter = structuredClone(this.reportFilter);
const runFilter = this.$refs.filters.find(f => f.id === "run");
presetReportFilter.runName =
runFilter?.selectedItems.map(i => i.id) ?? [];

const activePresetId = this.$refs.FilterMenu?.[0]?.activePresetId;

const preset = {
id: mode === "override" && activePresetId
? activePresetId
: -1,
name: this.presetName,
reportFilter: this.reportFilter
reportFilter: presetReportFilter
};

new Promise(resolve => {
Expand All @@ -660,6 +670,7 @@ export default {
handleThriftError("FAILURE", err);
});
},

deletePreset(preset_id) {
new Promise(resolve => {
ccService.getClient().deleteFilterPreset(preset_id,
Expand Down
Loading