Fix vue warnings#4934
Conversation
| helpMessage: { type: String, default: null }, | ||
| bus: { type: Object, required: true }, | ||
| value: { type: Array, required: true }, | ||
| value: { type: [ Array, Number, Object ], default: null }, |
There was a problem hiding this comment.
What was the reason setting it to accept arrays, numbers and objects? In the code this component is used 2 times and on both occasions it is getting a number so theoretically only numbers should be expected. Or did I miss something?
There was a problem hiding this comment.
Added it because of the Expected Array, got Object/Number/Null warning, but fixed the actual cause instead, getNumberOfFailedFiles() wasn't calling .toNumber(). value is just Number now.
| RunSortType | ||
| } from "@cc/report-server-types"; | ||
| import AnalysisInfoDialog from "@/components/AnalysisInfoDialog"; |
There was a problem hiding this comment.
This dialog was moved to the RunNameColumn itself where it gets activated. Because of this modification, the dialog can be removed from RunList entirely.
There was a problem hiding this comment.
Removed it from RunList.vue entirely. Also cleaned up the unused openAnalysisInfoDialog prop in RunNameColumn.vue and ExpandedRun.vue.
2 participants
Fixed:
TheHeader.vue - [Vue Router warn]: Discarded invalid param(s) "endpoint" when navigating - removed explicit endpoint param, Vue Router 4.1.4+ inherits it automatically
CheckerMessageFilter.vue - [Vue warn]: Property "setSelectedItems" was accessed during render but is not defined on instance - was referencing a non-existent local function instead of baseSelectOptionFilter.setSelectedItems
SingleLineWidget.vue - [Vue warn]: Invalid prop: type check failed for prop "value". Expected Array, got Null/Object/Number - prop type was too strict, broadened to [Array, Number, Object]
RunList.vue - [Vue warn]: Failed to resolve component: AnalysisInfoDialog - component was used in template but never imported
Statistics.vue - [Vue Router warn]: can no longer be used directly inside - updated to Vue 3 slot pattern
Statistics.vue - [Vue warn]: Runtime directive used on component with non-element root node - v-fill-height was on (fragment root), moved to a wrapping