Skip to content

bump upgrade view#4428

Merged
bfish713 merged 1 commit into
release-ff-upgrade-testfrom
bf/genesis
Jun 3, 2026
Merged

bump upgrade view#4428
bfish713 merged 1 commit into
release-ff-upgrade-testfrom
bf/genesis

Conversation

@bfish713

@bfish713 bfish713 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Closes #<ISSUE_NUMBER>

This PR:

This PR does not:

Key places to review:

@bfish713
bfish713 marked this pull request as ready for review June 3, 2026 15:21
@bfish713
bfish713 requested a review from sveitser as a code owner June 3, 2026 15:21
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@claude

claude Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @bfish713's task in 26s —— View job


Review: bump upgrade view

  • Gather context and read changed files
  • Review diff against origin/release-ff-upgrade-test
  • Check for existing review comments
  • Post review

Summary: This PR bumps the upgrade proposal window in data/genesis/staging-upgrade.toml from views 600–2000 to 6600–8000 (shifting both start_proposing_view and stop_proposing_view by +6000).

Review: This is a clean, minimal config-only change. No issues found.

  • The window size remains consistent (1400 views in both old and new values), so the upgrade proposal duration is preserved.
  • Both values are reasonable and maintain the expected relationship (start < stop).
  • No code logic, security, or performance concerns — this is purely a genesis config parameter adjustment.

LGTM 👍

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Nextest failures (1) in this run

Test Attempts Time (s) Main history
cliquenet::frame-handling::multiple_frames 1 0.03 passing

See the step summary for flaky tests and slowest tests.

@bfish713
bfish713 merged commit 0d43f70 into release-ff-upgrade-test Jun 3, 2026
136 of 141 checks passed
@bfish713
bfish713 deleted the bf/genesis branch June 3, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants