Fix misleading orchestrator client error level log

[imabdulbasit]

For an existing network, we don't use orchestrator because we may already have the config or we have fetched from peers.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[claude]

Claude finished @imabdulbasit's task in 33s —— View job

---

Code Review: Fix orchestrator client info error level log

• Gather context and understand changes
• Review code quality and correctness
• Check for security, performance, and testing concerns
• Post review

Summary

This is a small, well-motivated change. The else branch at context.rs:462-466 is hit when a node starts without an orchestrator client — i.e., the network config was loaded from storage or fetched from peers. This is the normal path for a node rejoining an existing network, not an error condition.

Feedback

The change looks good. Downgrading from tracing::error! to tracing::info! is the right call here. The previous error! level was misleading — it would fire on every non-orchestrated node start, which is expected behavior in production. The new log message ("no orchestrator configured") is also clearer than the old one ("Cannot get info from orchestrator client"), which implied a failure rather than a deliberate configuration choice.

The added comment explaining why this isn't an error is helpful context for future readers.

No issues found with security, performance, or testing — this is a log-level-only change with no behavioral impact.

---

[github-actions]

Successfully created backport PR for release-ff-upgrade-test:

• [Backport release-ff-upgrade-test] Fix misleading orchestrator client error level log #4438

[github-actions]

Nextest failures (1) in this run

Test	Attempts	Time (s)	Main history
hotshot-testing::test_epochs_combined_network::test_combined_network_cdn_crash_with_epochs::testtypes_::combinedimpl_::test_combined_network_cdn_crash_with_epochs	1	44.23	passing

See the step summary for flaky tests and slowest tests.