WIP: light client query service decaf sync#4576
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
| anyhow = { workspace = true } | ||
| clap = { workspace = true } | ||
| espresso-node = { workspace = true, default-features = false } | ||
| espresso-node = { workspace = true, default-features = false, features = ["embedded-db"] } |
There was a problem hiding this comment.
this seems wrong but probably doesn't affect the experiment here
Nextest failures (10) in this run
See the step summary for flaky tests and slowest tests. |
Nextest failures (3) in this run
See the step summary for flaky tests and slowest tests. |
We were using the epoch number from the QC in the finality proof to get the epoch number of the quorum required to verify a `LeafProof`. For QCs generated prior to the proof-of-stake upgrade, this would be `None`, which would cause the verifier to incorrectly use an `Assumption` hint, when it should be using the genesis, pre-epochs quorum. The fix uses the leaf height to compute the required epoch, which works regardless of whether the QC has an epoch number or not.
From #4576 We were using the epoch number from the QC in the finality proof to get the epoch number of the quorum required to verify a `LeafProof`. For QCs generated prior to the proof-of-stake upgrade, this would be `None`, which would cause the verifier to incorrectly use an `Assumption` hint, when it should be using the genesis, pre-epochs quorum. The fix uses the leaf height to compute the required epoch, which works regardless of whether the QC has an epoch number or not. (cherry picked from commit b7f098a)
2 participants
just for sharing