Skip to content

agents: re-add datadog logs usage instructions#4587

Open
sveitser wants to merge 1 commit into
mainfrom
ma/fix-dd-agents-md
Open

agents: re-add datadog logs usage instructions#4587
sveitser wants to merge 1 commit into
mainfrom
ma/fix-dd-agents-md

Conversation

@sveitser

Copy link
Copy Markdown
Collaborator

Current instructions are to brief, claude fails to look into pup README.

Current instructions are to brief, claude fails to look into pup README.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Claude finished @sveitser's task in 37s —— View job


Code Review: AGENTS.md — Datadog logs instructions

  • Gather context and review PR diff
  • Review referenced files for accuracy
  • Provide review feedback

LGTM — this is a good improvement.

The old instruction (See ./nix/pup/README.md) was too terse and lacked context about what pup is or why you'd use it. The new line fixes both issues:

-See ./nix/pup/README.md
+**Datadog logs/metrics/monitors:** Use `pup` (available in the dev shell) to query logs. See `nix/pup/README.md`

I verified the referenced nix/pup/README.md exists and its content aligns with the description — it covers authentication, log search queries, and aggregation examples for Datadog via pup.

One minor nit (non-blocking): the old path had a leading ./ while the new one drops it. Both work fine as human-readable pointers, and the nix/pup/README.md form is actually more consistent with how paths are referenced elsewhere in this file (e.g., crates/espresso/node/api/*.toml), so this is a positive change.

No issues found.

@sveitser sveitser enabled auto-merge June 24, 2026 13:40
@sveitser sveitser disabled auto-merge June 24, 2026 13:40
@sveitser sveitser enabled auto-merge June 24, 2026 13:40
@sveitser sveitser disabled auto-merge June 24, 2026 13:41
@sveitser sveitser enabled auto-merge (squash) June 24, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant