Revert "feat(hotshot): widen upgrade proposal window via propose_offset"

[lukaszrzasik]

Reverts #4611

[claude]

Claude finished @lukaszrzasik's task in 1m 22s —— View job

---

Review: Revert PR #4611

• Gather context and read changed files
• Review the diff against the original PR
• Provide review feedback

This is a clean mechanical revert of #4611. I verified:

1. Constants restored correctly — DEFAULT_UPGRADE_CONSTANTS values revert from {propose_offset: 20, decide_by_offset: 120, begin_offset: 125, finish_offset: 130} back to {5, 105, 110, 115}, matching the pre-feat(hotshot): widen upgrade proposal window via propose_offset #4611 state.

2. Test changes are consistent — The start_proposing_view parameter is removed from the test_upgrade_helper_with_nodes signature and from both call sites (test_upgrade_helper and test_epoch_reward_upgrade). The .upgrade_proposing_views(start_proposing_view, 1000) call is also removed from the test config builder chain.

3. No dangling references — The upgrade_proposing_views method (defined in crates/espresso/node/src/lib.rs:1318) and its usage in slow-tests/tests/epoch_reward_restart.rs:51 were pre-existing before feat(hotshot): widen upgrade proposal window via propose_offset #4611 and are not affected by this revert.

4. No issues found — No bugs, no missing changes, no inconsistencies. The inline comments on the constants were added by feat(hotshot): widen upgrade proposal window via propose_offset #4611 and are correctly removed as part of the revert.

LGTM — straightforward revert with no concerns.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[github-actions]

Nextest failures (3) in this run

Test	Attempts	Time (s)	Main history
hotshot-new-protocol::tests::legacy_cutover::perm_silence_all	1	34.05	passing
hotshot-testing::tests_2::tests_2::catchup::test_all_restart::testtypes_::pushcdnimpl_::test_all_restart	1	23.39	passing
hotshot-testing::tests_2::tests_2::catchup::test_all_restart::testtypesrandomizedleader_::pushcdnimpl_::test_all_restart	1	23.70	passing

See the step summary for flaky tests and slowest tests.

[github-actions]

Nextest failures (1) in this run

Test	Attempts	Time (s)	Main history
tests::integration::proof_of_stake::test_native_demo_drb_header_base	3	434.25	passing

See the step summary for flaky tests and slowest tests.