feat: change shakeViewForTimes function#432
Open
kusakusakusa wants to merge 1 commit intoEsqarrouth:masterfrom
Open
feat: change shakeViewForTimes function#432kusakusakusa wants to merge 1 commit intoEsqarrouth:masterfrom
kusakusakusa wants to merge 1 commit intoEsqarrouth:masterfrom
Conversation
Collaborator
|
I have little context about UIView. @goktugyil Would you mind taking a look ? |
Owner
|
I've never had the misalignment problem. When does it happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
The previous implementation of
shakeViewForTimes(_:)causes the view to be misaligned after the animation has ended. This implementation does not.I'm not sure how to test this and there were no previous tests to refer to 😅