Minor crash resolved#473
Open
ioskunal wants to merge 1 commit intoEsqarrouth:masterfrom
Open
Conversation
invalid check mistake resolved
Owner
|
Thanks for the PR. Is there an associated test with this? Did it run before? Does it run now? |
Author
|
Thanks for quick reply. I tested this manually. The loop has to be executed from |
Generated by 🚫 Danger |
Owner
|
Could you edit the test cases here so it gives an asset while running the code:
But doesn't give an assert with:
https://github.com/goktugyil/EZSwiftExtensions/blob/master/EZSwiftExtensionsTests/StringTests.swift |
Khalian
reviewed
Aug 26, 2018
| /// EZSE: Checks if String contains Emoji | ||
| public func includesEmoji() -> Bool { | ||
| for i in 0...length { | ||
| for i in 0..<length { |
Collaborator
There was a problem hiding this comment.
Could you write a unit test for this pls ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid check mistake resolved
Checklist