Surport Swift 5#499
Conversation
Khalian
left a comment
Khalian
left a comment
There was a problem hiding this comment.
The changes look relatively straightforward and minor. However the build fails because of https://travis-ci.org/goktugyil/EZSwiftExtensions. Xcode 10.0 cannot be installed on macOS 10.12.
What version of XCode and macOS X are you using to locally build them? We need to match that configuration with the travis.yml file on.
| } | ||
| } | ||
| // public func timePassed() -> TimePassed { |
There was a problem hiding this comment.
Why are we commenting this out?
| // | ||
|
|
||
| import Foundation | ||
| import AVFoundation |
| // Copyright (c) 2015 Goktug Yilmaz. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation |
|
I have created a remote branch ceeyang-Swift5.0, I will keep pushing in changes to fix builds and stuff, but I would need your help since I am out of date on all the XCode versions and MacOSX versions for latest swift stuff. Regardless, I am attempting a few expts here : #501. This is by no means the official PR for 5.0, this is to facilitate build fixes only. |
2 participants
Checklist