fixed accessing the wrong event-parameter when building fake join-/leave-messages

Author: BlvckBytes

Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java

@@ -343,20 +343,25 @@ public void onVanishStatusChange(final VanishStatusChangeEvent event) {
             return;
         }
 
+        // Note: getController() returns the vanished player due to a long-standing parameter swap in Commandvanish.
+        User user = (User) event.getController();
+
         if (event.getValue()) {
-            String quitMessage = ChatColor.YELLOW + event.getAffected().getName() + " left the game";
+            String quitMessage = ChatColor.YELLOW + user.getName() + " left the game";
 
-            if (ess.getSettings().isCustomQuitMessage())
-                quitMessage = buildQuitMessage((User) event.getAffected());;
+            if (ess.getSettings().isCustomQuitMessage()) {
+                quitMessage = buildQuitMessage(user);
+            }
 
             Bukkit.broadcastMessage(quitMessage);
             return;
         }
 
-        String joinMessage = ChatColor.YELLOW + event.getAffected().getName() + " joined the game";
+        String joinMessage = ChatColor.YELLOW + user.getName() + " joined the game";
 
-        if (ess.getSettings().isCustomJoinMessage())
-            joinMessage = buildJoinMessage((User) event.getAffected(), false, null);;
+        if (ess.getSettings().isCustomJoinMessage()) {
+            joinMessage = buildJoinMessage(user, false, null);
+        }
 
         Bukkit.broadcastMessage(joinMessage);
     }