Discord: Fix custom bot name requiring show-avatar (#6239)

Fixes #5878. Caused by a regression from
384f63b, we were checking for for the
legacy options when we should really be checking if
`mc-to-discord-name-format` is anything other than the bot name.

Author: JRoy

EssentialsDiscord/src/main/java/net/essentialsx/discord/DiscordSettings.java

@@ -202,6 +202,16 @@ public boolean isShowDisplayName() {
         return config.getBoolean("show-displayname", false);
     }
 
+    protected boolean isCustomBotName() {
+        if (isShowName() || isShowDisplayName()) {
+            return true;
+        }
+
+        final String format = getFormatString("mc-to-discord-name-format");
+
+        return format != null && !format.isEmpty() && !format.equals("{botname}");
+    }
+
     public String getAvatarURL() {
         return config.getString("avatar-url", "https://crafthead.net/helm/{uuid}");
     }

EssentialsDiscord/src/main/java/net/essentialsx/discord/JDADiscordService.java

@@ -367,7 +367,7 @@ public void updatePresence() {
     }
 
     public void updateTypesRelay() {
-        if (!getSettings().isShowAvatar() && !getSettings().isShowName() && !getSettings().isShowDisplayName()) {
+        if (!getSettings().isShowAvatar() && !getSettings().isCustomBotName()) {
             for (WrappedWebhookClient webhook : channelIdToWebhook.values()) {
                 webhook.close();
             }