O2Jam combo animation, Fix thread synchronization, Added new modifier, Fixed original o2jam health rules, Fix song background for other supported file and if no image inside o2jam file, Fix Color3 not handled while using Vulkan Render, Make note normal disappear while it pressed

Game/src/Scenes/GameplayScene.cpp

@@ -220,37 +220,30 @@ void GameplayScene::Render(double delta)
     }
 
     if (m_drawCombo && std::get<7>(scores) > 0) {
-        m_amplitude = 30.0;
-        m_wiggleTime = 60 * m_comboTimer;
+        const double amplitudeStart = 30.0; // Constants
+        const double decrement = 1.0;
+        const double animationSpeed = 60.0;
 
-        double decrement = 6.0;                           // Calculate the decrement for each frame
-        double totalDecrement = decrement * m_wiggleTime; // Calculate the total decrement based on the current frame/time
-
-        double currentAmplitude = m_amplitude - totalDecrement; // Adjust the amplitude based on the total decrement
-
-        if (currentAmplitude < 0.0) {
-            currentAmplitude = 0.0; // Stopper like this due compiler issues
-        }
-
-        if (m_comboTimer > 1.0) {     // Check if the previous animation hasn't finished
-            m_comboTimer = 0.0;       // Reset the timer
-            m_amplitude += decrement; // Increase the starting amplitude for the next animation
+        if (m_comboTimer >= 1.0) { // Animation finished, reset parameters for the next animation
+            m_comboTimer = 0.0;
+            m_amplitude = amplitudeStart;
+            m_drawCombo = false;
         }
+        else {
+            double targetAmplitude = amplitudeStart - decrement * m_comboTimer * animationSpeed * 6;
+            double currentAmplitude = (targetAmplitude > 0.0) ? targetAmplitude : 0.0;
 
-        m_comboLogo->Position2 = UDim2::fromOffset(0, currentAmplitude / 3.0);
-        m_comboLogo->Draw(delta);
+            m_comboLogo->Position2 = UDim2::fromOffset(0, currentAmplitude / 3.0); // Update position based on amplitude
+            m_comboNum->Position2 = UDim2::fromOffset(0, currentAmplitude);
 
-        m_comboNum->Position2 = UDim2::fromOffset(0, currentAmplitude);
-        m_comboNum->DrawNumber(std::get<7>(scores));
+            m_comboLogo->Draw(delta);
+            m_comboNum->DrawNumber(std::get<7>(scores));
 
-        m_comboTimer += delta;
-        if (m_comboTimer > 1.0) {
-            m_comboTimer = 0.0;
-            m_drawCombo = false;
+            m_comboTimer += delta;
         }
     }
 
-    if (m_drawLN && std::get<9>(scores) > 0) { // Same Animation logic like DrawCombo
+    if (m_drawLN && std::get<9>(scores) > 0) { // Same Animation logic like DrawCombo 
         m_amplitude = 5.0;
         m_wiggleTime = 60 * m_lnTimer;
 
@@ -263,11 +256,6 @@ void GameplayScene::Render(double delta)
             currentAmplitude = 0.0;
         }
 
-        if (m_lnTimer > 1.0) {
-            m_lnTimer = 0.0;
-            m_amplitude += decrement;
-        }
-
         m_lnLogo->Position2 = UDim2::fromOffset(0, currentAmplitude);
         m_lnLogo->Draw(delta);
 
@@ -279,7 +267,6 @@ void GameplayScene::Render(double delta)
         if (m_lnTimer > 1.0) {
             m_lnTimer = 0.0;
             m_drawLN = false;
-            m_lnLogo->Reset();
         }
     }