add method to retrieve the IP address for procmox runners

Author: elasticroentgen

ApiController.cs

@@ -1,5 +1,6 @@
 using GithubActionsOrchestrator.Database;
 using GithubActionsOrchestrator.Models;
+using GithubActionsOrchestrator.CloudControllers;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 using Npgsql.Internal;
@@ -69,7 +70,7 @@ public async Task<IResult> GetPotentialRunners(int jobId)
     }
 
     [Route("provision/{provisionId}")]
-    public async Task<IResult> GetProvisionScript(string provisionId,[FromHeader(Name = "X-API-KEY")] string apiKey)
+    public async Task<IResult> GetProvisionScript(string provisionId,[FromHeader(Name = "X-API-KEY")] string apiKey, [FromServices] IServiceProvider serviceProvider)
     {
         /*// Check if API key is provided
         if (string.IsNullOrEmpty(apiKey))
@@ -87,6 +88,29 @@ public async Task<IResult> GetProvisionScript(string provisionId,[FromHeader(Nam
         var runner = await db.Runners.Where(x => x.ProvisionId.ToLower() == provisionId).FirstOrDefaultAsync();
         if(runner == null)
             return Results.NotFound();
+
+        // Update the runner's IP address if using Proxmox and IP is still dummy
+        if (runner.Cloud == "pve" && (string.IsNullOrEmpty(runner.IPv4) || runner.IPv4 == "0.0.0.0/0"))
+        {
+            try
+            {
+                var proxmoxController = serviceProvider.GetService<ProxmoxCloudController>();
+                if (proxmoxController != null)
+                {
+                    var actualIpAddress = await proxmoxController.UpdateRunnerIpAddressAsync(runner.CloudServerId);
+                    if (actualIpAddress != "0.0.0.0/0")
+                    {
+                        runner.IPv4 = actualIpAddress;
+                        await db.SaveChangesAsync();
+                    }
+                }
+            }
+            catch (Exception ex)
+            {
+                // Log the error but don't fail the provision request
+                Console.WriteLine($"Failed to update IP for runner {runner.RunnerId}: {ex.Message}");
+            }
+        }
 
         return Results.Content(runner.ProvisionPayload);
 

CloudControllers/ProxmoxCloudController.cs

@@ -215,7 +215,93 @@ private async Task<string> WaitForTaskCompletionAsync(string taskId, string node
                 }
             }
 
-            await Task.Delay(1000);
+            await Task.Delay(500);
+        }
+    }
+
+    private async Task<string> GetVmIpAddressAsync(int vmId, string node, int timeoutSeconds = 120)
+    {
+        var endTime = DateTime.UtcNow.AddSeconds(timeoutSeconds);
+        
+        while (DateTime.UtcNow < endTime)
+        {
+            try
+            {
+                var response = await MakeApiCallAsync($"/nodes/{node}/qemu/{vmId}/agent/network-get-interfaces");
+                var networkJson = JsonSerializer.Deserialize<JsonElement>(response);
+                
+                if (networkJson.TryGetProperty("data", out var dataElement) && dataElement.TryGetProperty("result", out var interfaces))
+                {
+                    foreach (var iface in interfaces.EnumerateArray())
+                    {
+                        if (iface.TryGetProperty("name", out var nameElement) && 
+                            nameElement.GetString() != "lo" && 
+                            iface.TryGetProperty("ip-addresses", out var ipAddresses))
+                        {
+                            foreach (var ipAddr in ipAddresses.EnumerateArray())
+                            {
+                                if (ipAddr.TryGetProperty("ip-address-type", out var typeElement) &&
+                                    typeElement.GetString() == "ipv4" &&
+                                    ipAddr.TryGetProperty("ip-address", out var ipElement))
+                                {
+                                    var ip = ipElement.GetString();
+                                    if (!ip.StartsWith("169.254.") && !ip.StartsWith("127."))
+                                    {
+                                        _logger.LogInformation($"Retrieved IP address for VM {vmId}: {ip}");
+                                        return ip;
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+            catch (Exception ex)
+            {
+                _logger.LogDebug($"Failed to get IP for VM {vmId}, retrying... Error: {ex.Message}");
+            }
+            
+            await Task.Delay(3000);
+        }
+        
+        _logger.LogWarning($"Timeout waiting for IP address for VM {vmId}, falling back to dummy IP");
+        return "0.0.0.0/0";
+    }
+
+    public async Task<string> UpdateRunnerIpAddressAsync(long cloudServerId)
+    {
+        await _semaphore.WaitAsync();
+        try
+        {
+            var resourcesResponse = await MakeApiCallAsync("/cluster/resources?type=vm");
+            var resourcesJson = JsonSerializer.Deserialize<JsonElement>(resourcesResponse);
+            
+            string selectedNode = null;
+            
+            if (resourcesJson.TryGetProperty("data", out var dataArray))
+            {
+                foreach (var resource in dataArray.EnumerateArray())
+                {
+                    if (resource.TryGetProperty("vmid", out var vmidElement) && 
+                        vmidElement.GetInt32() == cloudServerId)
+                    {
+                        selectedNode = resource.GetProperty("node").GetString();
+                        break;
+                    }
+                }
+            }
+            
+            if (selectedNode == null)
+            {
+                _logger.LogWarning($"Unable to find VM with ID {cloudServerId} in Proxmox for IP update");
+                return "0.0.0.0/0";
+            }
+
+            return await GetVmIpAddressAsync((int)cloudServerId, selectedNode);
+        }
+        finally
+        {
+            _semaphore.Release();
         }
     }
 
@@ -230,7 +316,7 @@ public async Task<Machine> CreateNewRunner(string arch, string size, string runn
         await _semaphore.WaitAsync();
         string macaddress = string.Empty;
         int newVmId;
-        
+
         try
         {
             string selectedNode = _mainNode;