Improve type strictness

Author: NMertsch

src/europython_discord/registration/ticket.py

@@ -27,5 +27,6 @@ class Ticket(BaseModel):
     variation: str | None
 
     @computed_field
+    @property
     def key(self) -> str:
         return generate_ticket_key(order=self.order, name=self.name)

tests/program_notifications/test_session_to_embed.py

@@ -38,7 +38,7 @@ def session() -> Session:
                 website_url="https://example.com/speaker2",
             ),
         ],
-        start="2024-07-10T08:00:00+00:00",
+        start=datetime.fromisoformat("2024-07-10T08:00:00+00:00"),
         title="Example Session",
         track=None,
         tweet="",
@@ -136,6 +136,8 @@ def test_embed_color(session: Session, level: str, expected_color: int) -> None:
     """Test the color of the embed based on session level."""
     session.level = level
     embed = session_to_embed.create_session_embed(session, None)
+
+    assert embed.color is not None
     assert embed.color.value == expected_color
 
 
@@ -222,6 +224,8 @@ def test_create_author_from_speakers(session: Session) -> None:
     session.speakers[1].avatar = "https://example.com/avatar2.jpg"
     author = session_to_embed._create_author_from_speakers(session.speakers)
 
+    assert author is not None
+
     # Should combine the names of all speakers
     assert author["name"] == "Jane Doe, John Doe"
 
@@ -238,6 +242,7 @@ def test_create_author_from_speakers_with_no_avatar(session: Session) -> None:
     session.speakers[1].avatar = ""
 
     author = session_to_embed._create_author_from_speakers(session.speakers)
+    assert author is not None
     assert author["icon_url"] is None
 
 
@@ -250,6 +255,7 @@ def test_create_author_with_long_name(session: Session) -> None:
     assert len(session.speakers[0].name) > _AUTHOR_WIDTH
 
     author = session_to_embed._create_author_from_speakers(session.speakers)
+    assert author is not None
     assert author["name"] == (
         "This is a very long speaker name which exceeds our maximum author name length, "
         "so we expect it to be shortened by our [...]"

tests/registration/test_pretix_connector.py

@@ -454,7 +454,7 @@ async def test_cancelled_orders_are_removed(aiohttp_client, unused_tcp_port_fact
 
     # insert previously paid ticket
     ticket = Ticket(order="ABC01", name="Jane Doe", type="Business", variation=None)
-    pretix_connector.tickets_by_key[ticket.key] = [ticket]
+    pretix_connector.tickets_by_key[ticket.key] = {ticket}
 
     # fetch pretix data: ticket was cancelled
     await pretix_connector.fetch_pretix_data()